Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[openrr-gui] Pin zerocopy to 0.3.0 #216

Merged
merged 1 commit into from
Mar 5, 2021
Merged

[openrr-gui] Pin zerocopy to 0.3.0 #216

merged 1 commit into from
Mar 5, 2021

Conversation

taiki-e
Copy link
Contributor

@taiki-e taiki-e commented Mar 5, 2021

zerocopy 0.3.1 removed support for stable Rust. We want to use stable, so pin zerocopy to 0.3.0.

details

zerocopy 0.3.1 depends on min_const_generics that requires 1.51.0 (the current beta, it will be released as stable in 2021-03-25).
Therefore, it cannot be used in the current stable (1.50.0).

https://github.com/openrr/openrr/runs/2036728847?check_suite_focus=true

error[E0658]: const generics are unstable
   --> /home/runner/.cargo/registry/src/github.heygears.com-1ecc6299db9ec823/zerocopy-0.3.1/src/lib.rs:71:38
    |
71  |         unsafe impl<T: $trait, const N: usize> $trait for [T; N] {
    |                                      ^
...
263 | impl_for_composite_types!(FromBytes);
    | ------------------------------------- in this macro invocation
    |
    = note: see issue #74878 <https://github.com/rust-lang/rust/issues/74878> for more information
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

cc @joshlf Is this intentional? If so, it would be nice to have a note that warns us about stable Rust support is not guaranteed.

zerocopy 0.3.1 removed support for stable Rust.
@OTL OTL enabled auto-merge (rebase) March 5, 2021 05:44
@OTL OTL disabled auto-merge March 5, 2021 05:48
@OTL OTL merged commit 2d29c13 into main Mar 5, 2021
@OTL OTL deleted the taiki-e/zerocopy branch March 5, 2021 05:48
@joshlf
Copy link

joshlf commented Mar 5, 2021

This was a mistake - I've yanked 0.3.1, and will be releasing these changes as 0.4.0. Thanks for bringing this to my attention, and sorry for the breakage!

@taiki-e
Copy link
Contributor Author

taiki-e commented Mar 5, 2021

@joshlf Thanks for the fix!

@joshlf
Copy link

joshlf commented Mar 5, 2021

np!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants