[Backport 2.x] side navigation changes for notifications #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* side navigation changes for notifications Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix jest tests Signed-off-by: Riya Saxena <riysaxen@amazon.com> * navLinks changes Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fixed the issues Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fixed the issues Signed-off-by: Riya Saxena <riysaxen@amazon.com> * addressed the comments Signed-off-by: Riya Saxena <riysaxen@amazon.com> * addressed the comments Signed-off-by: Riya Saxena <riysaxen@amazon.com> * Update public/plugin.ts Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: Riya Saxena <riysaxen@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com> (cherry picked from commit 9e6066a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
zhichao-aws,
yuye-aws,
getsaurabh02,
sbcd90,
praveensameneni,
amsiglan and
AWSHurneyt
as code owners
SuZhou-Joe
approved these changes
Jul 22, 2024
|
@riysaxen-amzn Looks like the CI is failing here, but it succeeded in the original PR. Is that expected? |
I see, CI failed due to Cache cypress tests which doesn't have to do anything with the changes made through this PR. There's an open issue in the github to track failing Cypress tests it seems [[hashFiles() couldn't finish within 120 seconds.] (https://github.com/actions/runner/issues/1840) |
AWSHurneyt
approved these changes
Jul 22, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 9e6066a from #222.