Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Backport 2.x] Update template for alert summary with new log pattern tools #1057

Closed
wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 950437b from #1021.

* Update template for alert summary with log pattern

Signed-off-by: Sihan He <hesihan@amazon.com>

* Update ChangeLog

Signed-off-by: Sihan He <hesihan@amazon.com>

---------

Signed-off-by: Sihan He <hesihan@amazon.com>
(cherry picked from commit 950437b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@owaiskazi19
Copy link
Member

Let's resolve #1021 (comment) before merging this one @000FLMS

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.53%. Comparing base (606172d) to head (2a6ea7c).
Report is 2 commits behind head on 2.x.

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x    #1057   +/-   ##
=========================================
  Coverage     75.53%   75.53%           
  Complexity     1050     1050           
=========================================
  Files           101      101           
  Lines          5215     5215           
  Branches        498      498           
=========================================
  Hits           3939     3939           
  Misses         1038     1038           
  Partials        238      238           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@000FLMS
Copy link
Contributor

000FLMS commented Feb 10, 2025

Have created a new PR here #1058 @owaiskazi19

@owaiskazi19
Copy link
Member

owaiskazi19 commented Feb 10, 2025

@000FLMS do you have the permission to push the changelog change in this PR?

@000FLMS
Copy link
Contributor

000FLMS commented Feb 10, 2025

@000FLMS do you have the permission to push the changelog change in this PR?

Have tried and it seems I can't push any change in this PR.

@owaiskazi19
Copy link
Member

@000FLMS do you have the permission to push the changelog change in this PR?

Have tried and it seems I can't push any change in this PR.

You can create a manual PR to 2.x and we can close this one then

@dbwiddis
Copy link
Member

Have tried and it seems I can't push any change in this PR.

You can create a manual PR to 2.x and we can close this one then

Maintainers have the ability to cherry-pick and push into PRs but since this was created by opensearch-trigger-bot other contributors can't do it.

@000FLMS
Copy link
Contributor

000FLMS commented Feb 10, 2025

@000FLMS do you have the permission to push the changelog change in this PR?

Have tried and it seems I can't push any change in this PR.

You can create a manual PR to 2.x and we can close this one then

Have created a manual backport PR #1059
We can close this one.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants