Updates demo certs and admin keystore #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarshitChanpura
requested review from
bowenlan-amzn,
getsaurabh02,
lezzago,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
amsiglan,
sbcd90,
eirsep,
AWSHurneyt,
jowg-amazon,
r1walz and
vikasvb90
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1116 +/- ##
============================================
- Coverage 75.39% 75.34% -0.05%
Complexity 2814 2814
============================================
Files 367 367
Lines 17038 17038
Branches 2370 2370
============================================
- Hits 12846 12838 -8
- Misses 2890 2896 +6
- Partials 1302 1304 +2 ☔ View full report in Codecov by Sentry. |
|
should be merged post opensearch-project/security#4061 is merged |
DarshitChanpura
changed the title
bowenlan-amzn
approved these changes
Feb 20, 2024
Hailong-am
approved these changes
Feb 21, 2024
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 19, 2024
Signed-off-by: Darshit Chanpura <dchanp@amazon.com> (cherry picked from commit a30e4b8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
r1walz
pushed a commit
that referenced
this pull request
Mar 19, 2024
(cherry picked from commit a30e4b8) Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream change coming from security plugin: opensearch-project/security#4061
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.