upgrade upload-artifact to version 3 #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hailong-am
requested review from
bowenlan-amzn,
r1walz and
vikasvb90
as code owners
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
force-pushed
the
upload-artifact_upgrade
branch
from
d44385b to
4ad501c
Compare
Hailong-am
added
maintenance
5 tasks
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
force-pushed
the
upload-artifact_upgrade
branch
from
b448fb7 to
5e2f873
Compare
|
@Hailong-am Can you check the linux workflows which are failing? |
gargrajat
reviewed
Sep 16, 2024
| with: | ||
| name: index-management-plugin-ubuntu-latest | ||
| name: index-management-plugin-ubuntu-latest-${{ matrix.java }} |
There was a problem hiding this comment.
This probably should have
name: index-management-plugin-${{ matrix.os }}-${{ matrix.java }}
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
changed the title
|
CI failures are not related to upload-artifact |
vikasvb90
approved these changes
Sep 16, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
* upgrade upload-artifact to version 4 Signed-off-by: Hailong Cui <ihailong@amazon.com> * add overwrite as true Signed-off-by: Hailong Cui <ihailong@amazon.com> * use v3 as v4 need node.js 20 Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit 58add11) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 task
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
upgrade upload-artifact to version 3 as v1 and v2 are deprecated per https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.