-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update approximate_threshold to 15K documents #2229
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VijayanB
requested review from
heemin32,
navneet1v,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng and
shatejas
as code owners
October 22, 2024 07:17
VijayanB
changed the title
Update threshold to 15K documents
Update approximate_threshold to 15K documents
Oct 22, 2024
After comparing indexing and search performance, we are updating default value to be 15000. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
force-pushed
the
update-threshold
branch
from
October 22, 2024 07:20
04b7fee
to
d256e11
Compare
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
force-pushed
the
update-threshold
branch
from
October 22, 2024 21:39
d40ea4a
to
4849f36
Compare
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
force-pushed
the
update-threshold
branch
8 times, most recently
from
October 23, 2024 17:01
284624e
to
dbf499e
Compare
VijayanB
force-pushed
the
update-threshold
branch
from
October 23, 2024 18:15
dbf499e
to
aeb9b36
Compare
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
force-pushed
the
update-threshold
branch
from
October 23, 2024 18:27
aeb9b36
to
e2dcdc6
Compare
naveentatikonda
approved these changes
Oct 23, 2024
navneet1v
approved these changes
Oct 23, 2024
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2229-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 eb0a3c7454cb33346f135161beb21f46f43b8457
# Push it to GitHub
git push --set-upstream origin backport/backport-2229-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
VijayanB
added a commit
to VijayanB/k-NN-2
that referenced
this pull request
Oct 23, 2024
* Update threshold to 15K documents After comparing indexing and search performance, we are updating default value to be 15000. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Fix bwc test Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Update test method Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Flush data after index Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> --------- Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
added a commit
that referenced
this pull request
Oct 24, 2024
…2231) * Update approximate_threshold to 15K documents (#2229) * Update threshold to 15K documents After comparing indexing and search performance, we are updating default value to be 15000. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Fix bwc test Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Update test method Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Flush data after index Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> --------- Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Remove udpate cluster setting Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * update warmup rolling upgrade scenario Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> --------- Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 24, 2024
…2231) * Update approximate_threshold to 15K documents (#2229) * Update threshold to 15K documents After comparing indexing and search performance, we are updating default value to be 15000. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Fix bwc test Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Update test method Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Flush data after index Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> --------- Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Remove udpate cluster setting Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * update warmup rolling upgrade scenario Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> --------- Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> (cherry picked from commit bdbddcf)
VijayanB
added a commit
that referenced
this pull request
Oct 24, 2024
…2231) (#2234) * Update approximate_threshold to 15K documents (#2229) * Update threshold to 15K documents After comparing indexing and search performance, we are updating default value to be 15000. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Fix bwc test Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Update test method Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Flush data after index Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> --------- Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Remove udpate cluster setting Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * update warmup rolling upgrade scenario Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> --------- Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> (cherry picked from commit bdbddcf) Co-authored-by: Vijayan Balasubramanian <balasvij@amazon.com>
5 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After comparing indexing and search performance, we are updating default value to be 15000.
Updated bwc rolling upgrade test and restart test to reset threshold to 0 to build graph always. Few tests checks
for graph in cache and having 15K will break that test. Hence, when new cluster comes up, we will update the setting to 0, force merge if require, before doing any new indexing.
Related Issues
#1942
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.