Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Release 3.0] Update gradle to 8.10.2 to support JDK23 #2460

Merged

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Jan 28, 2025

Description

[Release 3.0] Update gradle to 8.10.2 to support JDK23

Related Issues

Closes #2432

Check List

  • [ ] New functionality includes testing.
  • [ ] New functionality has been documented.
  • [ ] API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • [ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@naveentatikonda
Copy link
Member

@peterzhuamazon windows CI is failing

java.lang.instrument.IllegalClassFormatException: Error while instrumenting java/sql/Timestamp with JaCoCo 0.8.10.202304240956/8ea9668.
»  	at org.jacoco.agent.rt.internal_4a7f17c.CoverageTransformer.transform(CoverageTransformer.java:94)
»  	at java.instrument/java.lang.instrument.ClassFileTransformer.transform(ClassFileTransformer.java:242)
»  	at java.instrument/sun.instrument.TransformerManager.transform(TransformerManager.java:188)
»  	at java.instrument/sun.instrument.InstrumentationImpl.transform(InstrumentationImpl.java:610)
»  	at java.base/java.lang.ClassLoader.defineClass2(Native Method)
»  	at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1116)
»  	at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:182)
»  	at java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:821)
»  	at java.base/jdk.internal.loader.BuiltinClassLoader.findClassInModuleOrNull(BuiltinClassLoader.java:741)
»  	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:665)
»  	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:700)
»  	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:669)
»  	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:639)
»  	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
»  	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:528)
»  	at java.base/java.lang.Class.forName0(Native Method)
»  	at java.base/java.lang.Class.forName(Class.java:462)
»  	at java.base/java.lang.Class.forName(Class.java:453)
»  	at org.yaml.snakeyaml.nodes.Tag.<clinit>(Tag.java:89)
»  	at org.yaml.snakeyaml.resolver.Resolver.addImplicitResolvers(Resolver.java:60)
»  	at org.yaml.snakeyaml.resolver.Resolver.<init>(Resolver.java:77)
»  	at com.fasterxml.jackson.dataformat.yaml.YAMLParser.<init>(YAMLParser.java:124)
»  	at com.fasterxml.jackson.dataformat.yaml.YAMLParser.<init>(YAMLParser.java:196)
»  	at com.fasterxml.jackson.dataformat.yaml.YAMLFactory._createParser(YAMLFactory.java:505)
»  	at com.fasterxml.jackson.dataformat.yaml.YAMLFactory.createParser(YAMLFactory.java:407)
»  	at org.opensearch.common.xcontent.yaml.YamlXContent.createParser(YamlXContent.java:115)
»  	at org.opensearch.common.settings.Settings$Builder.loadFromStream(Settings.java:1136)
»  	at org.opensearch.common.settings.Settings$Builder.loadFromPath(Settings.java:1118)
»  	at org.opensearch.node.InternalSettingsPreparer.prepareEnvironment(InternalSettingsPreparer.java:96)
»  	at org.opensearch.cli.EnvironmentAwareCommand.createEnv(EnvironmentAwareCommand.java:118)
»  	at org.opensearch.cli.EnvironmentAwareCommand.createEnv(EnvironmentAwareCommand.java:109)
»  	at org.opensearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:104)
»  	at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
»  	at org.opensearch.cli.MultiCommand.execute(MultiCommand.java:104)
»  	at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
»  	at org.opensearch.cli.Command.main(Command.java:101)
»  	at org.opensearch.common.settings.KeyStoreCli.main(KeyStoreCli.java:62)
»  Caused by: java.io.IOException: Error while instrumenting java/sql/Timestamp with JaCoCo 0.8.10.202304240956/8ea9668.
»  	at org.jacoco.agent.rt.internal_4a7f17c.core.instr.Instrumenter.instrumentError(Instrumenter.java:161)
»  	at org.jacoco.agent.rt.internal_4a7f17c.core.instr.Instrumenter.instrument(Instrumenter.java:111)
»  	at org.jacoco.agent.rt.internal_4a7f17c.CoverageTransformer.transform(CoverageTransformer.java:92)
»  	... 36 more
»  Caused by: java.lang.IllegalArgumentException: Unsupported class file major version 67
»  	at org.jacoco.agent.rt.internal_4a7f17c.asm.ClassReader.<init>(ClassReader.java:199)
»  	at org.jacoco.agent.rt.internal_4a7f17c.asm.ClassReader.<init>(ClassReader.java:180)
»  	at org.jacoco.agent.rt.internal_4a7f17c.asm.ClassReader.<init>(ClassReader.java:166)
»  	at org.jacoco.agent.rt.internal_4a7f17c.core.internal.instr.InstrSupport.classReaderFor(InstrSupport.java:280)
»  	at org.jacoco.agent.rt.internal_4a7f17c.core.instr.Instrumenter.instrument(Instrumenter.java:77)
»  	at org.jacoco.agent.rt.internal_4a7f17c.core.instr.Instrumenter.instrument(Instrumenter.java:109)
»  	... 37 more

> Task :integTest FAILED

FAILURE: Build failed with an exception.

* Where:
Build file 'D:\a\k-NN\k-NN\build.gradle' line: 413

@peterzhuamazon peterzhuamazon changed the title Update gradle to 8.10.2 to support JDK23 [Release 3.0] Update gradle to 8.10.2 to support JDK23 Jan 30, 2025
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Copy link
Member Author

Hi @naveentatikonda pushed a fix to the build.gradle.

Thanks.

@peterzhuamazon
Copy link
Member Author

The BWC test failure is not related.
Another PR #2429 is currently on that.

Thanks.

@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Jan 30, 2025

Build test failed on the macOS and success on LINUX/Windows:

Tests with failures:
 - org.opensearch.knn.index.codec.KNN990Codec.KNN990CodecTests.testBuildFromModelTemplate

@peterzhuamazon
Copy link
Member Author

Hi @Vikasht34 @naveentatikonda I think we can merge this as all gradle related failures has been resolved.

Thanks.

@naveentatikonda naveentatikonda merged commit c61eff4 into opensearch-project:main Jan 30, 2025
11 of 34 checks passed
@peterzhuamazon peterzhuamazon deleted the update-gradle-8.10.2 branch January 30, 2025 21:36
Vikasht34 pushed a commit to Vikasht34/k-NN that referenced this pull request Feb 12, 2025
…oject#2460)

* Update gradle to 8.10.2 to support JDK23

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Update license headers

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Bump jacoco to 0.8.12 to support JDK23

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

---------

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Enhancements Increases software capabilities beyond original client specifications release skip-changelog v3.0.0
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Bump gradle to 8.10.2 and add JDK23 as part of the github checks
4 participants