Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add checks to OpenSearch in auto-generated manifests. #519

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

dblock
Copy link
Member

@dblock dblock commented Sep 17, 2021

Signed-off-by: dblock dblock@dblock.org

Description

In #514 the generated manifests lacked basic checks. This adds version and build checks that ensures that the OpenSearch core builds successfully.

I didn't add any automatic checks to the plugins because those aren't always the same (e.g. security doesn't have a version check because it uses maven that only builds one of the flavors of snapshot vs. non-snapshot and therefore we cannot check version without hacks), and because those would fail without first building OpenSearch.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@dblock.org>
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2021

Codecov Report

Merging #519 (29cfb0e) into main (757a225) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #519      +/-   ##
==========================================
+ Coverage   70.25%   70.32%   +0.07%     
==========================================
  Files          59       59              
  Lines        1553     1557       +4     
==========================================
+ Hits         1091     1095       +4     
  Misses        462      462              
Impacted Files Coverage Δ
...undle-workflow/src/manifests_workflow/component.py 100.00% <100.00%> (ø)
...src/manifests_workflow/component_opensearch_min.py 100.00% <100.00%> (ø)
...workflow/src/manifests_workflow/input_manifests.py 95.65% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3519a6...29cfb0e. Read the comment docs.

Copy link
Member

@saratvemulapalli saratvemulapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand we'd like to start with OpenSearch but we should add support to all plugins.
As called out in the description we could leave out a few to start with but most of the plugins should be do-able.

@dblock
Copy link
Member Author

dblock commented Sep 17, 2021

I understand we'd like to start with OpenSearch but we should add support to all plugins.
As called out in the description we could leave out a few to start with but most of the plugins should be do-able.

We have support for all but 2 plugins (performance-analyzer-rca and security), see #437 for details.

This PR adds checks automatically. Because plugins require OpenSearch to first build and publish to maven local, the checks won't work unless OpenSearch is already present in the manifest. If a component increments a version, it will cause a new manifest to be generated without OpenSearch (it has not incremented its version yet). So the auto-PR will break 100% of the time, hence I didn't add checks to components.

@dblock dblock merged commit 74196ce into opensearch-project:main Sep 17, 2021
@dblock dblock deleted the add-manifest-checks branch September 17, 2021 17:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants