-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add OpenSearch 1.2.0 Build Manifests for next version #664
Add OpenSearch 1.2.0 Build Manifests for next version #664
Conversation
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
These components aren't ready to be added since they haven't incremented their versions to 1.2, and CI caught it. If job-scheduler and common-utils has incremented the version(s) you can add them. Note that for a given release we ask components to contribute themselves as part of the release checklist. |
…n main branch Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Working with @dbbaughe to ensure that Common-Utils, Job-Scheduler, and IM all updated to 1.2.0 in main branch before proceed to the merge. |
Codecov Report
@@ Coverage Diff @@
## main #664 +/- ##
=======================================
Coverage 86.85% 86.85%
=======================================
Files 68 68
Lines 1818 1818
=======================================
Hits 1579 1579
Misses 239 239 Continue to review full report at Codecov.
|
IM main isn't using 1.2, but it does work when we pass -Dopenseach.version=1.2.0 from CI here. I think you should still wait till main branches are using 1.2 (from Maven hopefully) before merging this. |
You should remove IM from this PR because IM needs at least one successful build of 1.2 OpenSearch artifacts to have -SNAPSHOT published to maven to pass 1.2 build. Just do the cron in this PR and then we can keep adding components. |
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
OpenSearch 1.2.0 success run in Jenkins for run 319, you can see the jars in maven snapshots: |
We should be good to merge this now. |
Btw, we have a feature request to automatically add new manifests to the build pipeline in #487. |
Signed-off-by: Peter Zhu zhujiaxi@amazon.com
Description
Add OpenSearch 1.2.0 Build Manifests for next version
Issues Resolved
#663
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.