Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add OpenSearch 1.2.0 Build Manifests for next version #664

Merged

Conversation

peterzhuamazon
Copy link
Member

Signed-off-by: Peter Zhu zhujiaxi@amazon.com

Description

Add OpenSearch 1.2.0 Build Manifests for next version

Issues Resolved

#663

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@dblock
Copy link
Member

dblock commented Sep 30, 2021

These components aren't ready to be added since they haven't incremented their versions to 1.2, and CI caught it. If job-scheduler and common-utils has incremented the version(s) you can add them.

Note that for a given release we ask components to contribute themselves as part of the release checklist.

…n main branch

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Copy link
Member Author

Working with @dbbaughe to ensure that Common-Utils, Job-Scheduler, and IM all updated to 1.2.0 in main branch before proceed to the merge.

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2021

Codecov Report

Merging #664 (292535a) into main (60b82a7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #664   +/-   ##
=======================================
  Coverage   86.85%   86.85%           
=======================================
  Files          68       68           
  Lines        1818     1818           
=======================================
  Hits         1579     1579           
  Misses        239      239           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1862bdd...292535a. Read the comment docs.

@dblock
Copy link
Member

dblock commented Sep 30, 2021

IM main isn't using 1.2, but it does work when we pass -Dopenseach.version=1.2.0 from CI here. I think you should still wait till main branches are using 1.2 (from Maven hopefully) before merging this.

@dblock
Copy link
Member

dblock commented Oct 1, 2021

You should remove IM from this PR because IM needs at least one successful build of 1.2 OpenSearch artifacts to have -SNAPSHOT published to maven to pass 1.2 build. Just do the cron in this PR and then we can keep adding components.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Copy link
Member Author

OpenSearch 1.2.0 success run in Jenkins for run 319, you can see the jars in maven snapshots:
https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/opensearch/1.2.0-SNAPSHOT/

@peterzhuamazon
Copy link
Member Author

We should be good to merge this now.

@dblock dblock requested a review from gaiksaya October 1, 2021 12:44
@dblock dblock merged commit 71fc487 into opensearch-project:main Oct 1, 2021
@dblock
Copy link
Member

dblock commented Oct 1, 2021

Btw, we have a feature request to automatically add new manifests to the build pipeline in #487.

@peterzhuamazon peterzhuamazon deleted the opensearch-1.2.0-manifest branch October 1, 2021 15:51
@peterzhuamazon peterzhuamazon self-assigned this Oct 1, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Requirements] IM needs JS 1.2.0 SPI in Maven Snapshots to work
5 participants