bugfix: adjusts to use retry_on_conflict on bulk #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolascb
force-pushed
the
fix/bulk-retry-on-conflict
branch
2 times, most recently
from
ead387d to
4a179dd
Compare
nicolascb
changed the title
marcosvfranca
previously approved these changes
Jan 17, 2023
|
Thank you! Can you please add a unit test for this, since we've visibly introduced a bug? |
Signed-off-by: Nicolas Barbosa <nicolas.barbosa@fretebras.com.br>
nicolascb
force-pushed
the
fix/bulk-retry-on-conflict
branch
from
4a179dd to
a0c0438
Compare
|
hello @dblock, I added a unit test for this case, can you review again please? |
|
Looking good! I unblocked tests. Add an entry to https://github.com/opensearch-project/opensearch-go/blob/main/CHANGELOG.md and I think this will be good to go assuming tests pass. Thank you. |
nicolascb
force-pushed
the
fix/bulk-retry-on-conflict
branch
from
214c9e3 to
4f04817
Compare
Signed-off-by: Nicolas Barbosa <nicolas.barbosa@fretebras.com.br>
nicolascb
force-pushed
the
fix/bulk-retry-on-conflict
branch
from
4f04817 to
bf2cf60
Compare
|
@dblock done =D |
Thank you @nicolascb! Unblocking the tests. |
VachaShah
approved these changes
Jan 19, 2023
dblock
approved these changes
Jan 19, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug fix.
Adjust to set
retry_on_conflictwhen using bulk indexer.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.