[GUIDE] Add index_lifecycle guide #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zethuman
requested review from
dblock,
VijayanB,
VachaShah and
Jakob3xD
as code owners
|
Want to combine all the guides into 1 PR and just add a single CHANGELOG line? May be easier. |
|
@dblock I already went through the hard way creating all the branches... |
|
Happy to merge in any state. Your DCO failure above does need to be fixed please. Amend your commits. |
Jakob3xD
reviewed
Apr 12, 2023
zethuman
force-pushed
the
feature/guides/index_lifecycle
branch
from
01c3664 to
b40ba67
Compare
Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com>
…project#271) * Bump github.com/aws/aws-sdk-go from 1.44.230 to 1.44.235 Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.230 to 1.44.235. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](aws/aws-sdk-go@v1.44.230...v1.44.235) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com>
* Add linter for markdown files Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> * Updated CHANGELOG.md Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> * Add make-script and update DEVELOPER_GUIDE.md Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> * Updated linter options Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> * Fixed mmarkdown files format Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> --------- Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com>
…t#272) Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com>
Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com>
Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com>
…ensearch-project#286) Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com> Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com>
Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com>
Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com>
Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com>
zethuman
force-pushed
the
feature/guides/index_lifecycle
branch
from
b40ba67 to
ca3b7dd
Compare
Jakob3xD
reviewed
Apr 12, 2023
Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com>
zethuman
force-pushed
the
feature/guides/index_lifecycle
branch
from
c445417 to
8c86b57
Compare
Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com>
|
@Jakob3xD indent was added, can you review it? Is this required for rest of guides? |
Jakob3xD
previously approved these changes
Apr 14, 2023
dblock
approved these changes
Apr 14, 2023
There was a problem hiding this comment.
Let's get this one merged.
@zethuman pick the next one you want to merge from your 5 PRs and let's only iterate on that? another option is to finish all the guides in 1 PR like I tried in #301, up to you.
We need to link these guides from README, don't we?
@Jakob3xD thanks for reviewing the content in this and subsequent PRs
Closed
|
@dblock as I understand it is no longer relevant? |
|
Yep, all good, thanks. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add guide to index_lifecycle.
Issues Resolved
Closes [#276, #279].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.