-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add Highlight field to SearchHit struct #654
Changes from all commits
f7cd93c
d743310
2ce8d15
0d59886
035de67
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -112,6 +112,7 @@ type NodesStats struct { | |
Repositories []json.RawMessage `json:"repositories"` | ||
AdmissionControl NodesStatsAdmissionControl `json:"admission_control"` | ||
Caches NodesStatsCaches `json:"caches"` | ||
RemoteStore NodeStatsRemoteStore `json:"remote_store"` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🗒️ Integration tests were failing due to this field that was added to the opensearch 2.18 response. The test was comparing the parsed response to the raw response and failing on the missing field. |
||
} | ||
|
||
// NodesStatsIndices is a sub type of NodesStats representing Indices information of the node | ||
|
@@ -729,3 +730,8 @@ type NodesStatsCaches struct { | |
StoreName string `json:"store_name"` | ||
} `json:"request_cache"` | ||
} | ||
|
||
// NodeStatsRemoteStore is a sub type of NodesStats | ||
type NodeStatsRemoteStore struct { | ||
LastSuccessfulFetchOfPinnedTimestamps int `json:"last_successful_fetch_of_pinned_timestamps"` | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -62,6 +62,7 @@ type SearchTemplateResp struct { | |
Took int `json:"took"` | ||
Timeout bool `json:"timed_out"` | ||
Shards ResponseShards `json:"_shards"` | ||
Status int `json:"status"` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🗒️ Integration tests were failing due to this field that was added to the opensearch 2.18 response. The test was comparing the parsed response to the raw response and failing on the missing field. |
||
Hits struct { | ||
Total struct { | ||
Value int `json:"value"` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗒️ This ensures that when running integration tests locally, docker isn't using an older cached version of
opensearch:latest
, and actually gets the most recent one that the CI build will be using.