-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Adds MatchedQueries field to SearchHit #663
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #663 +/- ##
==========================================
+ Coverage 57.29% 62.66% +5.37%
==========================================
Files 315 376 +61
Lines 9823 11133 +1310
==========================================
+ Hits 5628 6977 +1349
+ Misses 2902 2876 -26
+ Partials 1293 1280 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
MatchedQueries
field to SearchHit
MatchedQueries
field to SearchHit
Signed-off-by: 17sushmita <s.sushmita@zomato.com>
71c2a1a
to
aa4a4ef
Compare
Signed-off-by: 17sushmita <s.sushmita@zomato.com>
f064c80
to
ca49b37
Compare
Looks like integration tests are failing, not sure if it's related, take a look? |
a81f580
to
fe2f0dc
Compare
Signed-off-by: 17sushmita <s.sushmita@zomato.com>
fe2f0dc
to
5662bb0
Compare
@dblock Can you also merge the PR, I'm not able to merge it. Also, to use this code, will have to create a release. When will be releasing this? |
I'm retrying to specs, we need a passing build. There's an issue open for it, #568, if you/someone/anyone wants to take a look that would be helpful. Will merge when/if it passes.
Open an issue to release v. Next if you need it quickly, one of the maintainers can cut it fairly easily. |
@17sushmita https://github.com/opensearch-project/opensearch-go/actions/runs/13259031094/job/37011215963?pr=663 has failed repeatedly. I think JDK needs to be bumped to 21 in https://github.com/opensearch-project/opensearch-go/blob/main/.github/workflows/test-integration-unreleased.yml#L14. Can you please take a look? |
Signed-off-by: 17sushmita <s.sushmita@zomato.com>
7a4302c
to
927f29b
Compare
yes, java version was the issue, updated it to 21. All tests are passing now.
Yes @dblock , I need this quickly. can you pls help in creating release after it gets merged? |
I've raised an issue to create release - #666 |
Description
Describe what this change achieves.
Added MatchedQueries field in response struct of SearchHit.
This is done to add support for receiving matched queries in response when using
_name
with query clausesIssues Resolved
List any issues this PR will resolve, e.g. Closes [/issues/573].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.