Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adds MatchedQueries field to SearchHit #663

Merged
merged 4 commits into from
Feb 11, 2025

Conversation

17sushmita
Copy link
Contributor

Description

Describe what this change achieves.
Added MatchedQueries field in response struct of SearchHit.
This is done to add support for receiving matched queries in response when using _name with query clauses

Issues Resolved

List any issues this PR will resolve, e.g. Closes [/issues/573].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.66%. Comparing base (06a6dc8) to head (927f29b).
Report is 79 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #663      +/-   ##
==========================================
+ Coverage   57.29%   62.66%   +5.37%     
==========================================
  Files         315      376      +61     
  Lines        9823    11133    +1310     
==========================================
+ Hits         5628     6977    +1349     
+ Misses       2902     2876      -26     
+ Partials     1293     1280      -13     
Flag Coverage Δ
integration 54.79% <ø> (+3.95%) ⬆️
unit 15.48% <ø> (+2.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
opensearchapi/api_search.go 100.00% <ø> (ø)

... and 31 files with indirect coverage changes

@17sushmita 17sushmita changed the title added matched queries support Adds MatchedQueries field to SearchHit Feb 10, 2025
@17sushmita 17sushmita changed the title Adds MatchedQueries field to SearchHit Adds MatchedQueries field to SearchHit Feb 10, 2025
Signed-off-by: 17sushmita <s.sushmita@zomato.com>
Signed-off-by: 17sushmita <s.sushmita@zomato.com>
dblock
dblock previously approved these changes Feb 10, 2025
@dblock
Copy link
Member

dblock commented Feb 10, 2025

Looks like integration tests are failing, not sure if it's related, take a look?

@17sushmita 17sushmita force-pushed the matched-queries branch 2 times, most recently from a81f580 to fe2f0dc Compare February 11, 2025 08:42
Signed-off-by: 17sushmita <s.sushmita@zomato.com>
@17sushmita
Copy link
Contributor Author

Fixed the test case related to my code. It is passing -
image

dblock
dblock previously approved these changes Feb 11, 2025
@17sushmita
Copy link
Contributor Author

@dblock Can you also merge the PR, I'm not able to merge it.

Also, to use this code, will have to create a release. When will be releasing this?

@dblock
Copy link
Member

dblock commented Feb 11, 2025

@dblock Can you also merge the PR, I'm not able to merge it.

I'm retrying to specs, we need a passing build. There's an issue open for it, #568, if you/someone/anyone wants to take a look that would be helpful. Will merge when/if it passes.

Also, to use this code, will have to create a release. When will be releasing this?

Open an issue to release v. Next if you need it quickly, one of the maintainers can cut it fairly easily.

Signed-off-by: 17sushmita <s.sushmita@zomato.com>
@17sushmita
Copy link
Contributor Author

17sushmita commented Feb 11, 2025

yes, java version was the issue, updated it to 21. All tests are passing now.

Open an issue to release v. Next if you need it quickly, one of the maintainers can cut it fairly easily.

Yes @dblock , I need this quickly. can you pls help in creating release after it gets merged?

@dblock dblock merged commit a77a524 into opensearch-project:main Feb 11, 2025
56 checks passed
@17sushmita 17sushmita mentioned this pull request Feb 11, 2025
@17sushmita
Copy link
Contributor Author

I've raised an issue to create release - #666

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants