-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add basic HTTP compression #451
Conversation
Signed-off-by: Michael Liarakos <mliarakos@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mliarakos Thank you for contributing this, could you please add an entry to the CHANGELOG.md?
Signed-off-by: Michael Liarakos <mliarakos@gmail.com>
Updated. |
@mliarakos, thank you for contributing. Is there any reason you didn't add compression support for HTTP response but just requests? |
@pavelnemirovsky, response compression is already supported by configuring the library to add the |
Thank you. I was unable to make it work. I will double-check it. |
@mliarakos I double-checked, and it doesn’t work. It sends the Accept-Encoding header, but the HTTP client receiving the gzip or deflate stream doesn’t decode it properly... here is the log below:
|
@mliarakos any chance for your feedback? |
@pavelnemirovsky, WIP basic compression support for http responses in #543 |
Description
Add basic support for HTTP compression when writing to OpenSearch.
This PR adapts s4ch1n/elasticsearch-hadoop@d932775 to add basic HTTP compression support without upgrading the Apache HttpComponents dependency.
The elasticsearch-hadoop library and its HTTP compression fork use version 2.0 of the Apache License.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.