Remove obsolete Backported classes for jackson 1.5 support #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xtansia
requested changes
May 29, 2024
There was a problem hiding this comment.
Thanks for the contribution @asalamon74! Changes look reasonable to me, just need to adjust the changelog entry a bit
CHANGELOG.md
Outdated
| @@ -12,6 +12,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| ### Removed | |||
|
|
|||
| ### Fixed | |||
| - Remove obsolete Backported classes for jackson 1.5 support | |||
There was a problem hiding this comment.
This should be under ### Removed and include the PR link at the end of the line, additionally fix casing of backported and Jackson:
Suggested change
| - Remove obsolete Backported classes for jackson 1.5 support | |
| - Removed obsolete backported classes for Jackson 1.5 support |
Signed-off-by: Andras Salamon <andras.salamon@melda.info>
asalamon74
force-pushed
the
jackson_cleanup
branch
from
71f83db to
2906828
Compare
|
Thanks for the review @Xtansia I've updated the changelog. |
Xtansia
approved these changes
May 30, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This ancient commit 10 years ago ( b919c17 ) added Backported classes to support jackson 1.5
But the hadoop version was quickly updated back to 1.8.8: 76ca1a7
And the hadoop version in the project are not using 1.5 anymore:
hadoop 3.1.2: jackson 1.9.13
hadoop 2.7.6: jackson 1.9.13
hadoop 2.2.0: jackson 1.8.8
so I think that jackson 1.5 support is no longer imporant.
These hardwired classes make it difficult to bump the jackson version to 1.9.13
Issues Resolved
This PR removes the backported classes and makes it easier to bump the jackson version later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.