Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for datetime #255

Closed
wants to merge 2 commits into from
Closed

Conversation

kylepbit
Copy link
Contributor

Description

Previously datetime types would result in an NPE on retrieval, as the conversion would be unsupported. Map datetime to timestamp to support it.

Issues Resolved

#252

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Previously datetime types would result in an NPE on retrieval, as the conversion would be unsupported. Map datetime to timestamp to support it.
@codecov-commenter
Copy link

Codecov Report

Merging #255 (e2ba0a3) into main (6dae7b2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #255   +/-   ##
=========================================
  Coverage     99.90%   99.90%           
  Complexity     2638     2638           
=========================================
  Files           256      256           
  Lines          6442     6442           
  Branches        402      402           
=========================================
  Hits           6436     6436           
  Misses            5        5           
  Partials          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dae7b2...e2ba0a3. Read the comment docs.

@ghost
Copy link

ghost commented Nov 5, 2021

This PR can be closed as commits do not have --signoff. #267 is a duplicate of this PR with --signoff.

@kylepbit kylepbit closed this Nov 5, 2021
@joshuali925 joshuali925 added the tdvt Tableau test framework label Nov 24, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
tdvt Tableau test framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants