Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

SRVKP-5936: Close modal button is not working in dynamic plugin list pages #149

Conversation

lokanandaprabhu
Copy link
Member

Issue:
https://issues.redhat.com/browse/SRVKP-5936

Analysis / Root cause:
onClose function was not submitted to Modal component.

Solution Description:
Added onClose function to Modal component.

Screen shots / Gifs for design review:
----BEFORE---

Screen.Recording.2024-08-07.at.4.01.54.PM.mov

---AFTER---

Screen.Recording.2024-08-07.at.4.08.58.PM.mov

Unit test coverage report:
NA

Test setup:

  1. Install Pipelines operator and enable dynamic plugin
  2. Create a pipeline and click on start in kebab menu
  3. Click on X button to close the start pipeline modal

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Aug 7, 2024

@lokanandaprabhu: This pull request references SRVKP-5936 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "Pipelines 1.17.0" instead.

In response to this:

Issue:
https://issues.redhat.com/browse/SRVKP-5936

Analysis / Root cause:
onClose function was not submitted to Modal component.

Solution Description:
Added onClose function to Modal component.

Screen shots / Gifs for design review:
----BEFORE---

Screen.Recording.2024-08-07.at.4.01.54.PM.mov

---AFTER---

Screen.Recording.2024-08-07.at.4.08.58.PM.mov

Unit test coverage report:
NA

Test setup:

  1. Install Pipelines operator and enable dynamic plugin
  2. Create a pipeline and click on start in kebab menu
  3. Click on X button to close the start pipeline modal

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 7, 2024
Copy link
Contributor

openshift-ci bot commented Aug 7, 2024

@lokanandaprabhu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.13-e2e-tests-aws 42397a2 link false /test 4.13-e2e-tests-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vikram-raj
Copy link
Member

/retest

Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 6f886d8 into openshift-pipelines:main Aug 7, 2024
8 of 9 checks passed
@lokanandaprabhu
Copy link
Member Author

/cherry-pick release-v1.15.x

@openshift-cherrypick-robot

@lokanandaprabhu: new pull request created: #150

In response to this:

/cherry-pick release-v1.15.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants