-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
SRVKP-5936: Close modal button is not working in dynamic plugin list pages #149
SRVKP-5936: Close modal button is not working in dynamic plugin list pages #149
Conversation
@lokanandaprabhu: This pull request references SRVKP-5936 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "Pipelines 1.17.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lokanandaprabhu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@lokanandaprabhu: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
6f886d8
into
openshift-pipelines:main
/cherry-pick release-v1.15.x |
@lokanandaprabhu: new pull request created: #150 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Issue:
https://issues.redhat.com/browse/SRVKP-5936
Analysis / Root cause:
onClose function was not submitted to Modal component.
Solution Description:
Added onClose function to Modal component.
Screen shots / Gifs for design review:
----BEFORE---
Screen.Recording.2024-08-07.at.4.01.54.PM.mov
---AFTER---
Screen.Recording.2024-08-07.at.4.08.58.PM.mov
Unit test coverage report:
NA
Test setup:
Browser conformance: