Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

OAPE-35, OCPBUGS-45486: Rebase openshift/main with upstream v1.37.2 #37

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

chiragkyal
Copy link
Member

@chiragkyal chiragkyal commented Apr 2, 2025

Description of the change:

Rebase this repo to upstream v1.37.2 : https://github.com/operator-framework/ansible-operator-plugins/releases/tag/v1.37.2

Steps Followed

git remote add upstream https://github.com/operator-framework/ansible-operator-plugins.git

git fetch --all

git checkout -b rebase-upstream-v1.37.2

git merge v1.37.2

Solving Merge Conflicts

  • Got merge conflicts on the following files. Mostly related to version bumps. Accepted the Incoming Changes for all.
        both modified:   Makefile
	both modified:   go.mod
	both modified:   go.sum
	both modified:   images/ansible-operator/Pipfile
	both modified:   images/ansible-operator/Pipfile.lock
	both modified:   internal/version/version.go
	both modified:   testdata/memcached-molecule-operator/Makefile
  • Cross-checked the updated Pipfile and Pipfile.lock should match with upstream.
    • Since we want to keep downstream Pipfile in sync with upstream, avoid regenerating Pipfile.lock
  • Stagged those files
git commit

git push origin rebase-upstream-v1.37.2

Update Vendor

go mod tidy && go mod vendor

git add .
git commit -m "UPSTREAM: <drop>: go mod vendor"
git push origin rebase-upstream-v1.37.2

Update downstream requirement files

  • This time we got two issues

    • Conflict with setuptools_scm version, solved by adding requests-unixsocket into requirements-build.in
    • Strange issue with pip_find_builddeps.py script, where running it once creates extra setuptools>=77.0.3 deps, but running twice removes this. We had to add a hack to run this script twice. We could not find any better option. Slack thread.
  • Add a new helper script openshift/hack/find_individual_builddeps.py to find deps for individual packages using pip_find_builddeps.py

  • Run the following commands for verification

  • make -f openshift/Makefile check-collections

  • make check-requirements

Motivation for the change:
Closes :

acornett21 and others added 13 commits October 22, 2024 12:12
Signed-off-by: Adam D. Cornett <adc@redhat.com>
… corresponding scaffolding logic (#116)

Signed-off-by: Adam D. Cornett <adc@redhat.com>
Signed-off-by: Adam D. Cornett <adc@redhat.com>
* Update k8s dependencies to 1.31

* Updated k8s dependencies to 1.31
* Updated kubebuilder, controller-runtime, operator-lib & operator-registry
* Updated pipfile

Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in>

* Fixing tests

Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in>

* Update kind & setup-envtest versions

Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in>

* Regenerate go mod file

Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in>

* Update to latest patch versions

Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in>

---------

Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in>
Signed-off-by: Adam D. Cornett <adc@redhat.com>
Signed-off-by: Adam D. Cornett <adc@redhat.com>
Signed-off-by: Adam D. Cornett <adc@redhat.com>
Signed-off-by: Adam D. Cornett <adc@redhat.com>
Signed-off-by: Chirag Kyal <ckyal@redhat.com>
Signed-off-by: chiragkyal <ckyal@redhat.com>
Signed-off-by: Adam D. Cornett <adc@redhat.com>
ansible-operator-plugins release v1.37.2
Copy link

openshift-ci bot commented Apr 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chiragkyal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2025
@chiragkyal
Copy link
Member Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2025
@chiragkyal chiragkyal changed the title Rebase openshift/main with upstream v1.37.2 OAPE-35: Rebase openshift/main with upstream v1.37.2 Apr 2, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 2, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 2, 2025

@chiragkyal: This pull request references OAPE-35 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Description of the change:

Motivation for the change:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

…tainer image to be consistent with ART for 4.19

Signed-off-by: chiragkyal <ckyal@redhat.com>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 2, 2025

@chiragkyal: This pull request references OAPE-35 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Description of the change:

Rebase this repo to upstream v1.37.2 : https://github.com/operator-framework/ansible-operator-plugins/releases/tag/v1.37.2

Steps Followed

git remote add upstream https://github.com/operator-framework/ansible-operator-plugins.git

git fetch --all

git checkout -b rebase-upstream-v1.37.2

git merge v1.37.2

Solving Merge Conflicts

  • Got merge conflicts on the following files. Mostly related to version bumps. Accepted the Incoming Changes for all.
       both modified:   Makefile
  both modified:   go.mod
  both modified:   go.sum
  both modified:   images/ansible-operator/Pipfile
  both modified:   images/ansible-operator/Pipfile.lock
  both modified:   internal/version/version.go
  both modified:   testdata/memcached-molecule-operator/Makefile
  • Cross-checked the updated Pipfile and Pipfile.lock should match with upstream.
  • Stagged those files
git commit

git push origin rebase-upstream-v1.37.2

Update Vendor

go mod tidy && go mod vendor

git add .
git commit -m "UPSTREAM: <drop>: go mod vendor"
git push origin rebase-upstream-v1.37.2

Motivation for the change:
Closes : https://issues.redhat.com/browse/OAPE-35

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 2, 2025

@chiragkyal: This pull request references OAPE-35 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Description of the change:

Rebase this repo to upstream v1.37.2 : https://github.com/operator-framework/ansible-operator-plugins/releases/tag/v1.37.2

Steps Followed

git remote add upstream https://github.com/operator-framework/ansible-operator-plugins.git

git fetch --all

git checkout -b rebase-upstream-v1.37.2

git merge v1.37.2

Solving Merge Conflicts

  • Got merge conflicts on the following files. Mostly related to version bumps. Accepted the Incoming Changes for all.
       both modified:   Makefile
  both modified:   go.mod
  both modified:   go.sum
  both modified:   images/ansible-operator/Pipfile
  both modified:   images/ansible-operator/Pipfile.lock
  both modified:   internal/version/version.go
  both modified:   testdata/memcached-molecule-operator/Makefile
  • Cross-checked the updated Pipfile and Pipfile.lock should match with upstream.
    • Since we want to keep downstream Pipfile in sync with upstream, avoid regenerating Pipfile.lock
  • Stagged those files
git commit

git push origin rebase-upstream-v1.37.2

Update Vendor

go mod tidy && go mod vendor

git add .
git commit -m "UPSTREAM: <drop>: go mod vendor"
git push origin rebase-upstream-v1.37.2

Motivation for the change:
Closes : https://issues.redhat.com/browse/OAPE-35

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Signed-off-by: chiragkyal <ckyal@redhat.com>
Signed-off-by: chiragkyal <ckyal@redhat.com>
@chiragkyal chiragkyal force-pushed the rebase-upstream-v1.37.2 branch from 510f245 to cb1b125 Compare April 7, 2025 12:26
@chiragkyal chiragkyal changed the title OAPE-35: Rebase openshift/main with upstream v1.37.2 OAPE-35, OCPBUGS-45486: Rebase openshift/main with upstream v1.37.2 Apr 7, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Apr 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 7, 2025

@chiragkyal: This pull request references OAPE-35 which is a valid jira issue.

This pull request references Jira Issue OCPBUGS-45486, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @emmajiafan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Description of the change:

Rebase this repo to upstream v1.37.2 : https://github.com/operator-framework/ansible-operator-plugins/releases/tag/v1.37.2

Steps Followed

git remote add upstream https://github.com/operator-framework/ansible-operator-plugins.git

git fetch --all

git checkout -b rebase-upstream-v1.37.2

git merge v1.37.2

Solving Merge Conflicts

  • Got merge conflicts on the following files. Mostly related to version bumps. Accepted the Incoming Changes for all.
       both modified:   Makefile
  both modified:   go.mod
  both modified:   go.sum
  both modified:   images/ansible-operator/Pipfile
  both modified:   images/ansible-operator/Pipfile.lock
  both modified:   internal/version/version.go
  both modified:   testdata/memcached-molecule-operator/Makefile
  • Cross-checked the updated Pipfile and Pipfile.lock should match with upstream.
    • Since we want to keep downstream Pipfile in sync with upstream, avoid regenerating Pipfile.lock
  • Stagged those files
git commit

git push origin rebase-upstream-v1.37.2

Update Vendor

go mod tidy && go mod vendor

git add .
git commit -m "UPSTREAM: <drop>: go mod vendor"
git push origin rebase-upstream-v1.37.2

Motivation for the change:
Closes : https://issues.redhat.com/browse/OAPE-35

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from emmajiafan April 7, 2025 16:06
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 7, 2025

@chiragkyal: This pull request references OAPE-35 which is a valid jira issue.

This pull request references Jira Issue OCPBUGS-45486, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @emmajiafan

In response to this:

Description of the change:

Rebase this repo to upstream v1.37.2 : https://github.com/operator-framework/ansible-operator-plugins/releases/tag/v1.37.2

Steps Followed

git remote add upstream https://github.com/operator-framework/ansible-operator-plugins.git

git fetch --all

git checkout -b rebase-upstream-v1.37.2

git merge v1.37.2

Solving Merge Conflicts

  • Got merge conflicts on the following files. Mostly related to version bumps. Accepted the Incoming Changes for all.
       both modified:   Makefile
  both modified:   go.mod
  both modified:   go.sum
  both modified:   images/ansible-operator/Pipfile
  both modified:   images/ansible-operator/Pipfile.lock
  both modified:   internal/version/version.go
  both modified:   testdata/memcached-molecule-operator/Makefile
  • Cross-checked the updated Pipfile and Pipfile.lock should match with upstream.
    • Since we want to keep downstream Pipfile in sync with upstream, avoid regenerating Pipfile.lock
  • Stagged those files
git commit

git push origin rebase-upstream-v1.37.2

Update Vendor

go mod tidy && go mod vendor

git add .
git commit -m "UPSTREAM: <drop>: go mod vendor"
git push origin rebase-upstream-v1.37.2

Motivation for the change:
Closes :

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 7, 2025

@chiragkyal: This pull request references OAPE-35 which is a valid jira issue.

This pull request references Jira Issue OCPBUGS-45486, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @emmajiafan

In response to this:

Description of the change:

Rebase this repo to upstream v1.37.2 : https://github.com/operator-framework/ansible-operator-plugins/releases/tag/v1.37.2

Steps Followed

git remote add upstream https://github.com/operator-framework/ansible-operator-plugins.git

git fetch --all

git checkout -b rebase-upstream-v1.37.2

git merge v1.37.2

Solving Merge Conflicts

  • Got merge conflicts on the following files. Mostly related to version bumps. Accepted the Incoming Changes for all.
       both modified:   Makefile
  both modified:   go.mod
  both modified:   go.sum
  both modified:   images/ansible-operator/Pipfile
  both modified:   images/ansible-operator/Pipfile.lock
  both modified:   internal/version/version.go
  both modified:   testdata/memcached-molecule-operator/Makefile
  • Cross-checked the updated Pipfile and Pipfile.lock should match with upstream.
    • Since we want to keep downstream Pipfile in sync with upstream, avoid regenerating Pipfile.lock
  • Stagged those files
git commit

git push origin rebase-upstream-v1.37.2

Update Vendor

go mod tidy && go mod vendor

git add .
git commit -m "UPSTREAM: <drop>: go mod vendor"
git push origin rebase-upstream-v1.37.2

Update downstream requirement files

  • This time we got two issues
    • Conflict with setuptools_scm version, solved by adding requests-unixsocket into requirements-build.in
    • Strange issue with pip_find_builddeps.py script, where running it once creates extra setuptools>=77.0.3 deps, but running twice removes this. We had to add a hack to run this script twice. We could not find any better option. Slack thread.
  • Run the following commands for verification
  • make -f openshift/Makefile check-collections
  • make check-requirements

Motivation for the change:
Closes :

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 7, 2025

@chiragkyal: This pull request references OAPE-35 which is a valid jira issue.

This pull request references Jira Issue OCPBUGS-45486, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @emmajiafan

In response to this:

Description of the change:

Rebase this repo to upstream v1.37.2 : https://github.com/operator-framework/ansible-operator-plugins/releases/tag/v1.37.2

Steps Followed

git remote add upstream https://github.com/operator-framework/ansible-operator-plugins.git

git fetch --all

git checkout -b rebase-upstream-v1.37.2

git merge v1.37.2

Solving Merge Conflicts

  • Got merge conflicts on the following files. Mostly related to version bumps. Accepted the Incoming Changes for all.
       both modified:   Makefile
  both modified:   go.mod
  both modified:   go.sum
  both modified:   images/ansible-operator/Pipfile
  both modified:   images/ansible-operator/Pipfile.lock
  both modified:   internal/version/version.go
  both modified:   testdata/memcached-molecule-operator/Makefile
  • Cross-checked the updated Pipfile and Pipfile.lock should match with upstream.
    • Since we want to keep downstream Pipfile in sync with upstream, avoid regenerating Pipfile.lock
  • Stagged those files
git commit

git push origin rebase-upstream-v1.37.2

Update Vendor

go mod tidy && go mod vendor

git add .
git commit -m "UPSTREAM: <drop>: go mod vendor"
git push origin rebase-upstream-v1.37.2

Update downstream requirement files

  • This time we got two issues

    • Conflict with setuptools_scm version, solved by adding requests-unixsocket into requirements-build.in
    • Strange issue with pip_find_builddeps.py script, where running it once creates extra setuptools>=77.0.3 deps, but running twice removes this. We had to add a hack to run this script twice. We could not find any better option. Slack thread.
  • Add a new helper script openshift/hack/find_individual_builddeps.py to find deps for individual packages using pip_find_builddeps.py

  • Run the following commands for verification

  • make -f openshift/Makefile check-collections

  • make check-requirements

Motivation for the change:
Closes :

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Signed-off-by: chiragkyal <ckyal@redhat.com>
Signed-off-by: chiragkyal <ckyal@redhat.com>
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR labels Apr 9, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 9, 2025

@chiragkyal: This pull request references OAPE-35 which is a valid jira issue.

This pull request references Jira Issue OCPBUGS-45486, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @emmajiafan

In response to this:

Description of the change:

Rebase this repo to upstream v1.37.2 : https://github.com/operator-framework/ansible-operator-plugins/releases/tag/v1.37.2

Steps Followed

git remote add upstream https://github.com/operator-framework/ansible-operator-plugins.git

git fetch --all

git checkout -b rebase-upstream-v1.37.2

git merge v1.37.2

Solving Merge Conflicts

  • Got merge conflicts on the following files. Mostly related to version bumps. Accepted the Incoming Changes for all.
       both modified:   Makefile
  both modified:   go.mod
  both modified:   go.sum
  both modified:   images/ansible-operator/Pipfile
  both modified:   images/ansible-operator/Pipfile.lock
  both modified:   internal/version/version.go
  both modified:   testdata/memcached-molecule-operator/Makefile
  • Cross-checked the updated Pipfile and Pipfile.lock should match with upstream.
    • Since we want to keep downstream Pipfile in sync with upstream, avoid regenerating Pipfile.lock
  • Stagged those files
git commit

git push origin rebase-upstream-v1.37.2

Update Vendor

go mod tidy && go mod vendor

git add .
git commit -m "UPSTREAM: <drop>: go mod vendor"
git push origin rebase-upstream-v1.37.2

Update downstream requirement files

  • This time we got two issues

    • Conflict with setuptools_scm version, solved by adding requests-unixsocket into requirements-build.in
    • Strange issue with pip_find_builddeps.py script, where running it once creates extra setuptools>=77.0.3 deps, but running twice removes this. We had to add a hack to run this script twice. We could not find any better option. Slack thread.
  • Add a new helper script openshift/hack/find_individual_builddeps.py to find deps for individual packages using pip_find_builddeps.py

  • Run the following commands for verification

  • make -f openshift/Makefile check-collections

  • make check-requirements

Motivation for the change:
Closes :

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@chiragkyal
Copy link
Member Author

@emmajiafan This PR is not yet ready for QE testing, we are still working on some fixes. We will let you know once we are good with the changes. Mind removing the labels?

Signed-off-by: chiragkyal <ckyal@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2025
Copy link

openshift-ci bot commented Apr 9, 2025

New changes are detected. LGTM label has been removed.

@emmajiafan
Copy link

@emmajiafan This PR is not yet ready for QE testing, we are still working on some fixes. We will let you know once we are good with the changes. Mind removing the labels?

no problem.

Copy link

openshift-ci bot commented Apr 9, 2025

@chiragkyal: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants