-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
OAPE-35, OCPBUGS-45486: Rebase openshift/main with upstream v1.37.2 #37
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Adam D. Cornett <adc@redhat.com>
… corresponding scaffolding logic (#116) Signed-off-by: Adam D. Cornett <adc@redhat.com>
Signed-off-by: Adam D. Cornett <adc@redhat.com>
* Update k8s dependencies to 1.31 * Updated k8s dependencies to 1.31 * Updated kubebuilder, controller-runtime, operator-lib & operator-registry * Updated pipfile Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in> * Fixing tests Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in> * Update kind & setup-envtest versions Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in> * Regenerate go mod file Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in> * Update to latest patch versions Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in> --------- Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in>
Signed-off-by: Adam D. Cornett <adc@redhat.com>
Signed-off-by: Adam D. Cornett <adc@redhat.com>
Signed-off-by: Adam D. Cornett <adc@redhat.com>
Signed-off-by: Adam D. Cornett <adc@redhat.com>
Signed-off-by: Chirag Kyal <ckyal@redhat.com>
Signed-off-by: chiragkyal <ckyal@redhat.com>
Signed-off-by: Adam D. Cornett <adc@redhat.com>
ansible-operator-plugins release v1.37.2
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chiragkyal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
@chiragkyal: This pull request references OAPE-35 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
…tainer image to be consistent with ART for 4.19 Signed-off-by: chiragkyal <ckyal@redhat.com>
@chiragkyal: This pull request references OAPE-35 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@chiragkyal: This pull request references OAPE-35 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Signed-off-by: chiragkyal <ckyal@redhat.com>
Signed-off-by: chiragkyal <ckyal@redhat.com>
510f245
to
cb1b125
Compare
@chiragkyal: This pull request references OAPE-35 which is a valid jira issue. This pull request references Jira Issue OCPBUGS-45486, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@chiragkyal: This pull request references OAPE-35 which is a valid jira issue. This pull request references Jira Issue OCPBUGS-45486, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@chiragkyal: This pull request references OAPE-35 which is a valid jira issue. This pull request references Jira Issue OCPBUGS-45486, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@chiragkyal: This pull request references OAPE-35 which is a valid jira issue. This pull request references Jira Issue OCPBUGS-45486, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Signed-off-by: chiragkyal <ckyal@redhat.com>
Signed-off-by: chiragkyal <ckyal@redhat.com>
@chiragkyal: This pull request references OAPE-35 which is a valid jira issue. This pull request references Jira Issue OCPBUGS-45486, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@emmajiafan This PR is not yet ready for QE testing, we are still working on some fixes. We will let you know once we are good with the changes. Mind removing the labels? |
Signed-off-by: chiragkyal <ckyal@redhat.com>
New changes are detected. LGTM label has been removed. |
no problem. |
@chiragkyal: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description of the change:
Rebase this repo to upstream v1.37.2 : https://github.com/operator-framework/ansible-operator-plugins/releases/tag/v1.37.2
Steps Followed
Solving Merge Conflicts
Pipfile
andPipfile.lock
should match with upstream.Pipfile
in sync with upstream, avoid regeneratingPipfile.lock
Update Vendor
golang v1.23
.Update downstream requirement files
This time we got two issues
setuptools_scm
version, solved by addingrequests-unixsocket
intorequirements-build.in
pip_find_builddeps.py
script, where running it once creates extrasetuptools>=77.0.3
deps, but running twice removes this. We had to add a hack to run this script twice. We could not find any better option. Slack thread.Add a new helper script
openshift/hack/find_individual_builddeps.py
to find deps for individual packages usingpip_find_builddeps.py
Run the following commands for verification
make -f openshift/Makefile check-collections
make check-requirements
Motivation for the change:
Closes :