NE-1809: Add new OLM channel for 1.2 release #142
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@alebedev87: This pull request references NE-1809 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
alebedev87
force-pushed
the
stable-1-2
branch
from
c708a21 to
a04a63f
Compare
|
/test e2e-aws-rosa-operator |
|
/assign |
|
/test e2e-aws-rosa-operator |
1 similar comment
|
/test e2e-aws-rosa-operator |
|
/retest |
1 similar comment
|
/retest |
alebedev87
force-pushed
the
stable-1-2
branch
from
a04a63f to
a210ba1
Compare
|
The operator secret provisioning failed. The CI PR which aims at addressing this intermittent problem: openshift/release#60039. /test e2e-aws-operator |
alebedev87
force-pushed
the
stable-1-2
branch
from
a210ba1 to
12a3a73
Compare
| - image: openshift.io/aws-load-balancer-operator:latest | ||
| name: "" | ||
| - image: quay.io/aws-load-balancer-operator/aws-load-balancer-operator-bundle:v1.1.0 | ||
| - image: quay.io/aws-load-balancer-operator/aws-load-balancer-operator-bundle:v1.2.0 | ||
| name: "" | ||
| - image: quay.io/aws-load-balancer-operator/aws-load-balancer-operator:latest | ||
| - image: quay.io/openshift/origin-kube-rbac-proxy:latest |
There was a problem hiding this comment.
Can you add something to the commit message that explains/documents the changes to image registries and tags?
- kube-rbac-proxy now being pulled from quay with latest instead of specific tag
- aws-load-balancer-operator now being pulled from openshift.io instead of quay
There was a problem hiding this comment.
Updated the commit message to explain kube-rbac-proxy and annotation changes. aws-load-balancer-operator image is just a placeholded used by default in Makefile, it's coming from bundle/ and substituted during CI tests.
For info - the catalog is not used in the CI (operator is deployed from the bundle directly) or by any customer.
| features.operators.openshift.io/disconnected: "false" | ||
| features.operators.openshift.io/fips-compliant: "true" | ||
| features.operators.openshift.io/proxy-aware: "true" | ||
| features.operators.openshift.io/tls-profiles: "false" | ||
| features.operators.openshift.io/token-auth-aws: "true" | ||
| features.operators.openshift.io/token-auth-azure: "false" | ||
| features.operators.openshift.io/token-auth-gcp: "false" |
There was a problem hiding this comment.
Can you add something to the commit message that explains the new feature configuration? I see where proxy-aware config changed, but there are some new (required?) changes as well.
Or, is it changed here just to match the existing config in
bundle/manifests/aws-load-balancer-operator.clusterserviceversion.yaml
and config/manifests/bases/aws-load-balancer-operator.clusterserviceversion.yaml?
There was a problem hiding this comment.
Or, is it changed here just to match the existing config in
bundle/manifests/aws-load-balancer-operator.clusterserviceversion.yaml
and config/manifests/bases/aws-load-balancer-operator.clusterserviceversion.yaml?
Yes. The catalog generation is a not optimal and has to be done manually for the moment. I'm working on fixing this (openshift/release#57465).
- Updated bundle metadata in `bundle.Dockerfile` and `bundle/metadata/annotations.yaml` with `1.2` channel.
- Updated `config/manifests/` to use `1.2` version for CSV.
- Regenerated the bundle using `make bundle` command.
- Updated `catalog/` using `make catalog` command:
- Added `1.2` channel.
- Updated bundle image to `1.2.0` tag.
- Updated infrastructure annotation according to latest changes (openshift#128).
- Updated kube-rbac-proxy image according to latest changes (openshift#116).
- Updated `docs/versioning.md` with `1.2.0` version.
alebedev87
force-pushed
the
stable-1-2
branch
from
12a3a73 to
e494808
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: candita The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/label px-approved Docs is enough for this feature. |
openshift-ci
bot
added
the
px-approved
|
/label docs-approved |
openshift-ci
bot
added
the
docs-approved
|
@alebedev87: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
@alebedev87: This pull request references NE-1809 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
bundle.Dockerfileandbundle/metadata/annotations.yamlwith new channel.config/manifests/to use the new version for CSV.make bundlecommand.catalog/with new bundle version and new minor version channel usingmake catalogcommand.docs/versioning.mdwith the new version.