Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bug 1949262: jsonnet: add hard anti-affinity to Prometheuses #1135

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

dgrisonnet
Copy link
Member

@dgrisonnet dgrisonnet commented Apr 27, 2021

Add hard anti-affinity constraints on hostname to the platform
and user-workload-monitoring Prometheuses to comply with the
high-availability conventions.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@openshift-ci-robot
Copy link
Contributor

@dgrisonnet: This pull request references Bugzilla bug 1949262, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

Bug 1949262: jsonnet: add hard anti-affinity to Prometheuses

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 27, 2021
@openshift-ci-robot
Copy link
Contributor

@dgrisonnet: This pull request references Bugzilla bug 1949262, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

Bug 1949262: jsonnet: add hard anti-affinity to Prometheuses

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2021
@dgrisonnet
Copy link
Member Author

@simonpasquier should we open a follow-up BZ or JIRA ticket for Alertmanager? As you mentioned on the BZ, we can't do anything to it for now. ref: https://bugzilla.redhat.com/show_bug.cgi?id=1949262#c1

Add hard anti-affinity constraints on hostname to the platform
and user-workload-monitoring Prometheuses to comply with the
high-availability conventions.

Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
@simonpasquier
Copy link
Contributor

/hold
until the CI is fixed

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2021
@simonpasquier
Copy link
Contributor

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2021
@simonpasquier
Copy link
Contributor

/retest

@simonpasquier
Copy link
Contributor

@dgrisonnet yes we have a JIRA ticket: https://issues.redhat.com/browse/MON-1004

@simonpasquier
Copy link
Contributor

/test e2e-agnostic

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 29, 2021

@dgrisonnet: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-single-node 7056585 link /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@simonpasquier
Copy link
Contributor

/test e2e-agnostic

@simonpasquier
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dgrisonnet,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 7f12f86 into openshift:master Apr 29, 2021
@openshift-ci-robot
Copy link
Contributor

@dgrisonnet: All pull requests linked via external trackers have merged:

Bugzilla bug 1949262 has been moved to the MODIFIED state.

In response to this:

Bug 1949262: jsonnet: add hard anti-affinity to Prometheuses

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants