Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bug 2008540: remove alert HighlyAvailableWorkloadIncorrectlySpread #1488

Merged
merged 1 commit into from
Dec 20, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- [#1481](https://github.com/openshift/cluster-monitoring-operator/pull/1481) Removing one of the AlertmanagerClusterFailedToSendAlerts alerts
- [#1373](https://github.com/openshift/cluster-monitoring-operator/pull/1373) Enable admins to toggle the [query_log_file](https://prometheus.io/docs/guides/query-log/#enable-the-query-log) setting for Prometheus.
- [#1491](https://github.com/openshift/cluster-monitoring-operator/pull/1491) Rename alerts `AggregatedAPIErrors to KubeAggregatedAPIErrors` and `AggregatedAPIDown to KubeAggregatedAPIDown`.
- [#1488](https://github.com/openshift/cluster-monitoring-operator/pull/1488) Removing the alert HighlyAvailableWorkloadIncorrectlySpread.

## 4.9

Expand Down
33 changes: 0 additions & 33 deletions assets/cluster-monitoring-operator/prometheus-rule.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,39 +28,6 @@ spec:
for: 15m
labels:
severity: warning
- alert: HighlyAvailableWorkloadIncorrectlySpread
annotations:
description: Workload {{ $labels.namespace }}/{{ $labels.workload }} is incorrectly
spread across multiple nodes which breaks high-availability requirements.
Since the workload is using persistent volumes, manual intervention is needed.
Please follow the guidelines provided in the runbook of this alert to fix
this issue.
runbook_url: https://github.com/openshift/runbooks/blob/master/alerts/HighlyAvailableWorkloadIncorrectlySpread.md
summary: Highly-available workload is incorrectly spread across multiple nodes
and manual intervention is needed.
expr: |
count without (node)
(
group by (node, workload, namespace)
(
kube_pod_info{node!=""}
* on(namespace,pod) group_left(workload)
(
max by(namespace, pod, workload) (kube_pod_spec_volumes_persistentvolumeclaims_info)
* on(namespace,pod) group_left(workload)
(
namespace_workload_pod:kube_pod_owner:relabel
* on(namespace,workload,workload_type) group_left()
(
count without(pod) (namespace_workload_pod:kube_pod_owner:relabel{namespace=~"(openshift-.*|kube-.*|default)"}) > 1
)
)
)
)
) == 1
for: 1h
labels:
severity: warning
- name: openshift-kubernetes.rules
rules:
- expr: sum(rate(container_cpu_usage_seconds_total{container="",pod!=""}[5m]))
Expand Down
33 changes: 0 additions & 33 deletions jsonnet/rules.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -22,39 +22,6 @@ function(params) {
severity: 'warning',
},
},
{
expr: |||
count without (node)
(
group by (node, workload, namespace)
(
kube_pod_info{node!=""}
* on(namespace,pod) group_left(workload)
(
max by(namespace, pod, workload) (kube_pod_spec_volumes_persistentvolumeclaims_info)
* on(namespace,pod) group_left(workload)
(
namespace_workload_pod:kube_pod_owner:relabel
* on(namespace,workload,workload_type) group_left()
(
count without(pod) (namespace_workload_pod:kube_pod_owner:relabel{%(namespaceSelector)s}) > 1
)
)
)
)
) == 1
||| % cfg,
alert: 'HighlyAvailableWorkloadIncorrectlySpread',
'for': '1h',
annotations: {
description: 'Workload {{ $labels.namespace }}/{{ $labels.workload }} is incorrectly spread across multiple nodes which breaks high-availability requirements. Since the workload is using persistent volumes, manual intervention is needed. Please follow the guidelines provided in the runbook of this alert to fix this issue.',
summary: 'Highly-available workload is incorrectly spread across multiple nodes and manual intervention is needed.',
runbook_url: 'https://github.com/openshift/runbooks/blob/master/alerts/HighlyAvailableWorkloadIncorrectlySpread.md',
},
labels: {
severity: 'warning',
},
},
],
},
{
Expand Down
1 change: 0 additions & 1 deletion jsonnet/utils/sanitize-rules.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,6 @@ local includeRunbooks = {
AlertmanagerFailedReload: openShiftRunbookCMO('AlertmanagerFailedReload.md'),
ClusterOperatorDegraded: openShiftRunbookCMO('ClusterOperatorDegraded.md'),
ClusterOperatorDown: openShiftRunbookCMO('ClusterOperatorDown.md'),
HighlyAvailableWorkloadIncorrectlySpread: openShiftRunbook('alerts/HighlyAvailableWorkloadIncorrectlySpread.md'),
KubeAPIDown: openShiftRunbookCMO('KubeAPIDown.md'),
KubeDeploymentReplicasMismatch: openShiftRunbookCMO('KubeDeploymentReplicasMismatch.md'),
KubeJobFailed: openShiftRunbookCMO('KubeJobFailed.md'),
Expand Down
61 changes: 0 additions & 61 deletions test/rules/bz2006561.yaml

This file was deleted.

Loading