OCPBUGS-5353: unstack dashboards with limit markers.

[raptorsun]

• I added CHANGELOG entry for this change.
• No user facing changes, so no entry in CHANGELOG was needed.

Dashboards showing CPU / memory usage used to stack the limit markers such as limit/request/quota over other metrics create confusion for users reading the diagrams. So we unstack all metrics in the charts containing these limit markers.

This is the result of unstacking metrics:

This is what it looks like when stacking metrics:

[openshift-ci-robot]

@raptorsun: This pull request references Jira Issue OCPBUGS-5353, which is invalid:

• expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

• I added CHANGELOG entry for this change.
• No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[raptorsun]

/jira refresh

[openshift-ci-robot]

@raptorsun: This pull request references Jira Issue OCPBUGS-5353, which is invalid:

• expected the bug to target the "4.13.0" version, but it targets "4.13" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[slashpai]

/retest

[openshift-ci-robot]

@raptorsun: This pull request references Jira Issue OCPBUGS-5353, which is invalid:

• expected the bug to target the "4.13.0" version, but it targets "4.13" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

• I added CHANGELOG entry for this change.
• No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@raptorsun: This pull request references Jira Issue OCPBUGS-5353, which is invalid:

• expected the bug to target the "4.13.0" version, but it targets "4.13" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

• I added CHANGELOG entry for this change.
• No user facing changes, so no entry in CHANGELOG was needed.

Dashboards showing CPU / memory usage used to stack the limit markers such as limit/request/quota over other metrics create confusion for users reading the diagrams. So we unstack all metrics in the charts containing these limit markers.

This is the result of unstacking metrics:

This is what it looks like when stacking metrics:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[raptorsun]

/jira refresh

[openshift-ci-robot]

@raptorsun: This pull request references Jira Issue OCPBUGS-5353, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.0) matches configured target version for branch (4.13.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[simonpasquier]

can we make the change upstream?

[raptorsun]

can we make the change upstream?

The upstream defines these dashboards for Grafana which is able to mix both stacked and unstacked metrics in the same chart, while in Openshift Console we can choose either stacked or unstacked for all the metrics in the same chart.

The fix should probably better stay in the scope of Openshift. 😅

[simonpasquier]

Ok! can you add the explanation next to the added jsonnet code (with a link to the JIRA bug)?
Also did we discuss this issue with the console folks? Is there something to improve on this side (e.g. to support stacked and unstacked series on the same graph)?

[raptorsun]

Ok! can you add the explanation next to the added jsonnet code (with a link to the JIRA bug)? Also did we discuss this issue with the console folks? Is there something to improve on this side (e.g. to support stacked and unstacked series on the same graph)?

Yup. An explanation has been added to the file dashboards.libsonnet as well as on the JIRA bug ticket. I will check with the console team on what shall we do to the charts in UI.

[raptorsun]

/retest-required

[simonpasquier]

/test e2e-agnostic-upgrade
/skip

[simonpasquier]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raptorsun, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [raptorsun,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 2b4844d and 2 for PR HEAD 4f18d47 in total

[openshift-ci]

@raptorsun: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-single-node	4f18d47	link	false	/test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[raptorsun]

/test e2e-agnostic-upgrade

[openshift-ci-robot]

@raptorsun: All pull requests linked via external trackers have merged:

• openshift/cluster-monitoring-operator#1868

Jira Issue OCPBUGS-5353 has been moved to the MODIFIED state.

In response to this:

• I added CHANGELOG entry for this change.
• No user facing changes, so no entry in CHANGELOG was needed.

Dashboards showing CPU / memory usage used to stack the limit markers such as limit/request/quota over other metrics create confusion for users reading the diagrams. So we unstack all metrics in the charts containing these limit markers.

This is the result of unstacking metrics:

This is what it looks like when stacking metrics:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[raptorsun]

/cherry-pick release-4.12

[openshift-cherrypick-robot]

@raptorsun: #1868 failed to apply on top of branch "release-4.12":

Applying: unstack dashboards with limit markers.
Using index info to reconstruct a base tree...
M	CHANGELOG.md
M	manifests/0000_90_cluster-monitoring-operator_01-dashboards.yaml
Falling back to patching base and 3-way merge...
Auto-merging manifests/0000_90_cluster-monitoring-operator_01-dashboards.yaml
Auto-merging CHANGELOG.md
CONFLICT (content): Merge conflict in CHANGELOG.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 unstack dashboards with limit markers.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.