Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[MON-2902] Add nodeExporter.collectors.tcpstat settings. #1876

Merged
merged 1 commit into from
Feb 16, 2023
Merged

[MON-2902] Add nodeExporter.collectors.tcpstat settings. #1876

merged 1 commit into from
Feb 16, 2023

Conversation

raptorsun
Copy link
Contributor

@raptorsun raptorsun commented Feb 1, 2023 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

This PR follows #1855
Adding enablement flag for tcpstat collector of Node Exporter.

https://issues.redhat.com/browse/MON-2902

This PR is the base to #1888

@openshift-ci openshift-ci bot requested review from jan--f and sthaha February 1, 2023 18:25
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2023
@raptorsun
Copy link
Contributor Author

/retest-required

@raptorsun
Copy link
Contributor Author

/retest-required

@simonpasquier
Copy link
Contributor

/skip

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2023
simonpasquier
simonpasquier reviewed Feb 13, 2023
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2023
@simonpasquier
Copy link
Contributor

cc @bburt-rh for docs, @Senthamilarasu-STA for PX and @juzhao for QE.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2023
@raptorsun raptorsun mentioned this pull request Feb 13, 2023
Merged
2 tasks
@raptorsun
Copy link
Contributor Author

/retest-required

@raptorsun
Copy link
Contributor Author

Merge conflict has been fixed :)

@raptorsun raptorsun requested review from simonpasquier and removed request for jan--f and sthaha February 14, 2023 09:32
@simonpasquier
Copy link
Contributor

/lgtm
/skip

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2023
@raptorsun raptorsun mentioned this pull request Feb 14, 2023
Merged
2 tasks
@jan--f
Copy link
Contributor

jan--f commented Feb 14, 2023

/lgtm
@bburt-rh @juzhao @Senthamilarasu-STA kindly requesting your attention on this.

@bburt-rh
Copy link
Contributor

/lgtm

@raptorsun raptorsun mentioned this pull request Feb 14, 2023
Merged
2 tasks
@jan--f
Copy link
Contributor

jan--f commented Feb 14, 2023

/lgtm

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Feb 14, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2023
@raptorsun
Copy link
Contributor Author

A new commit is pushed to correct a typo of "collector" in documentation.

@bburt-rh
Copy link
Contributor

/lgtm

@Senthamilarasu-STA
Copy link

/label px-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR lgtm Indicates that a PR is ready to be merged. labels Feb 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bburt-rh, jan--f, raptorsun, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jan--f,raptorsun,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@raptorsun
Copy link
Contributor Author

/retest-required

@juzhao
Copy link
Contributor

juzhao commented Feb 16, 2023

@Tai-RedHat please test with PR, if no issue, add qe-approved label

@simonpasquier
Copy link
Contributor

/skip
/retest

@Tai-RedHat
Copy link

test PR with cluster-bot, new features implemented
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 16, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d4d3ad1 and 2 for PR HEAD 748b656 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2023 •
edited
Loading

@raptorsun: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node 748b656 link false /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@raptorsun
Copy link
Contributor Author

/test e2e-agnostic-operator

@openshift-merge-robot openshift-merge-robot merged commit b225152 into openshift:master Feb 16, 2023
@martinkennelly
Copy link

How can this be enabled at day 1?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@simonpasquier simonpasquier Awaiting requested review from simonpasquier

Assignees

@jan--f jan--f

@simonpasquier simonpasquier

@bburt-rh bburt-rh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@raptorsun @simonpasquier @jan--f @bburt-rh @Senthamilarasu-STA @juzhao @Tai-RedHat @openshift-ci-robot @martinkennelly @openshift-merge-robot