MON-2895: toggle netlink implementation of netclass collector #1894

raptorsun · 2023-02-15T14:37:23Z

I added CHANGELOG entry for this change.
No user facing changes, so no entry in CHANGELOG was needed.

This PR follows #1893 . It should be merged after that one.

openshift-ci-robot · 2023-02-15T14:37:27Z

@raptorsun: This pull request references MON-2895 which is a valid jira issue.

In response to this:

I added CHANGELOG entry for this change.

No user facing changes, so no entry in CHANGELOG was needed.

This PR follows #1893 . It should be merged after that one.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

raptorsun · 2023-02-15T21:23:48Z

/hold
until #1893 is merged.

raptorsun · 2023-02-16T08:05:44Z

/retest-required

pkg/manifests/types.go

raptorsun · 2023-02-16T16:24:06Z

/test e2e-agnostic-operator

raptorsun · 2023-02-17T12:52:23Z

/test e2e-agnostic-operator

raptorsun · 2023-02-17T20:03:56Z

/test e2e-agnostic-operator

raptorsun · 2023-02-22T21:20:28Z

/test e2e-aws-single-node

raptorsun · 2023-02-23T08:58:18Z

/retest-required

simonpasquier

/lgtm

Senthamilarasu-STA · 2023-02-27T10:50:04Z

/label px-approved

raptorsun · 2023-02-27T17:22:47Z

The PR #1893 has been merged.
/unhold

raptorsun · 2023-02-27T17:23:42Z

Hello @Tai-RedHat @bburt-rh , the PR is ready for review, could you please have a look? 🙋‍♂️

Tai-RedHat · 2023-02-28T08:28:52Z

tested PR with cluster-bot, new feature implemented.
/label qe-approved

bburt-rh · 2023-02-28T15:12:08Z

Documentation/api.md

+| Property | Type | Description |
+| -------- | ---- | ----------- |
+| enabled | bool | A Boolean flag that enables or disables the `netclass` collector. |
+| useNetlink | bool | A Boolean flag that activates the netlink implementation of the `netclass` collector. This improves performance of `netclass` collector while omitting these metrics: `node_network_address_assign_type`, `node_network_name_assign_type`, `node_network_device_id`. |


Suggested change

| useNetlink | bool | A Boolean flag that activates the netlink implementation of the `netclass` collector. This improves performance of `netclass` collector while omitting these metrics: `node_network_address_assign_type`, `node_network_name_assign_type`, `node_network_device_id`. |

| useNetlink | bool | A Boolean flag that activates the `netlink` implementation of the `netclass` collector. This implementation improves the performance of the `netclass` collector by omitting these metrics: `node_network_address_assign_type`, `node_network_name_assign_type`, `node_network_device_id`. |

change to "by omitting these metrics" if the performance improvement is a result of omitting the metrics.

bburt-rh · 2023-02-28T15:13:25Z

Documentation/openshiftdocs/modules/nodeexportercollectornetclassconfig.adoc

+| Property | Type | Description 
+|enabled|bool|A Boolean flag that enables or disables the `netclass` collector.
+
+|useNetlink|bool|A Boolean flag that activates the netlink implementation of the `netclass` collector. This improves performance of `netclass` collector while omitting these metrics: `node_network_address_assign_type`, `node_network_name_assign_type`, `node_network_device_id`.


Suggested change

|useNetlink|bool|A Boolean flag that activates the netlink implementation of the `netclass` collector. This improves performance of `netclass` collector while omitting these metrics: `node_network_address_assign_type`, `node_network_name_assign_type`, `node_network_device_id`.

|useNetlink|bool|A Boolean flag that activates the `netlink` implementation of the `netclass` collector. This implementation improves the performance of the `netclass` collector by omitting these metrics: `node_network_address_assign_type`, `node_network_name_assign_type`, `node_network_device_id`.

bburt-rh · 2023-02-28T15:14:02Z

pkg/manifests/types.go

+type NodeExporterCollectorNetClassConfig struct {
+	// A Boolean flag that enables or disables the `netclass` collector.
+	Enabled bool `json:"enabled,omitempty"`
+	// A Boolean flag that activates the netlink implementation of the `netclass` collector.


Suggested change

// A Boolean flag that activates the netlink implementation of the `netclass` collector.

// A Boolean flag that activates the `netlink` implementation of the `netclass` collector.

bburt-rh · 2023-02-28T15:14:35Z

pkg/manifests/types.go

+	// A Boolean flag that enables or disables the `netclass` collector.
+	Enabled bool `json:"enabled,omitempty"`
+	// A Boolean flag that activates the netlink implementation of the `netclass` collector.
+	// This improves performance of `netclass` collector while omitting these metrics:


Suggested change

// This improves performance of `netclass` collector while omitting these metrics:

// This implementation improves the performance of the `netclass` collector by omitting these metrics:

bburt-rh · 2023-02-28T15:17:30Z

@raptorsun Added a few suggested changes, but otherwise LGTM.

…ter.

raptorsun · 2023-02-28T15:51:32Z

@raptorsun Added a few suggested changes, but otherwise LGTM.

Thank you for the review :D
The documentation has been updated accordingly in the new commit.

bburt-rh · 2023-02-28T17:48:07Z

/label docs-approved

raptorsun · 2023-02-28T18:26:28Z

/retest-required

openshift-ci · 2023-02-28T20:44:50Z

@raptorsun: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

JoaoBraveCoding

/lgtm

openshift-ci · 2023-03-01T10:22:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoaoBraveCoding, raptorsun, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoaoBraveCoding,raptorsun,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 15, 2023

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 15, 2023

openshift-ci bot requested review from jan--f and simonpasquier February 15, 2023 14:40

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2023

raptorsun force-pushed the feature/MON-2895 branch from 4d96dfb to e562835 Compare February 15, 2023 21:22

raptorsun changed the title ~~[WIP] MON-2895: toggle netlink implementation of netclass collector~~ MON-2895: toggle netlink implementation of netclass collector Feb 15, 2023

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 15, 2023

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2023

simonpasquier reviewed Feb 16, 2023

View reviewed changes

pkg/manifests/types.go Outdated Show resolved Hide resolved

pkg/manifests/types.go Outdated Show resolved Hide resolved

raptorsun force-pushed the feature/MON-2895 branch from e562835 to 25aaae5 Compare February 16, 2023 11:41

raptorsun force-pushed the feature/MON-2895 branch from 25aaae5 to d8910a5 Compare February 17, 2023 10:19

raptorsun force-pushed the feature/MON-2895 branch 4 times, most recently from 3d5729b to 11739c3 Compare February 22, 2023 17:01

simonpasquier reviewed Feb 23, 2023

View reviewed changes

openshift-ci bot assigned simonpasquier Feb 23, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2023

openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Feb 27, 2023

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2023

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 28, 2023

bburt-rh reviewed Feb 28, 2023

View reviewed changes

add toggle netlink implementation of netclass collector in Node Expor…

f5c760e

…ter.

raptorsun force-pushed the feature/MON-2895 branch from 11739c3 to f5c760e Compare February 28, 2023 15:50

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2023

openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Feb 28, 2023

JoaoBraveCoding approved these changes Mar 1, 2023

View reviewed changes

openshift-ci bot assigned JoaoBraveCoding Mar 1, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2023

openshift-merge-robot merged commit 6b62af6 into openshift:master Mar 1, 2023

simonpasquier mentioned this pull request Mar 3, 2023

OCPBUGS-8215: bugfix in Node Exporter argument setting + turn off netlink mode of netclass collector #1911

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MON-2895: toggle netlink implementation of netclass collector #1894

MON-2895: toggle netlink implementation of netclass collector #1894

raptorsun commented Feb 15, 2023

openshift-ci-robot commented Feb 15, 2023 •

edited by openshift-ci bot

Loading

raptorsun commented Feb 15, 2023

raptorsun commented Feb 16, 2023

raptorsun commented Feb 16, 2023

raptorsun commented Feb 17, 2023

raptorsun commented Feb 17, 2023

raptorsun commented Feb 22, 2023

raptorsun commented Feb 23, 2023

simonpasquier left a comment

Senthamilarasu-STA commented Feb 27, 2023

raptorsun commented Feb 27, 2023

raptorsun commented Feb 27, 2023

Tai-RedHat commented Feb 28, 2023

bburt-rh Feb 28, 2023 •

edited

Loading

bburt-rh Feb 28, 2023 •

edited

Loading

bburt-rh Feb 28, 2023

bburt-rh Feb 28, 2023 •

edited

Loading

bburt-rh commented Feb 28, 2023

raptorsun commented Feb 28, 2023

bburt-rh commented Feb 28, 2023

raptorsun commented Feb 28, 2023

openshift-ci bot commented Feb 28, 2023

JoaoBraveCoding left a comment

openshift-ci bot commented Mar 1, 2023

	\| useNetlink \| bool \| A Boolean flag that activates the netlink implementation of the `netclass` collector. This improves performance of `netclass` collector while omitting these metrics: `node_network_address_assign_type`, `node_network_name_assign_type`, `node_network_device_id`. \|
	\| useNetlink \| bool \| A Boolean flag that activates the `netlink` implementation of the `netclass` collector. This implementation improves the performance of the `netclass` collector by omitting these metrics: `node_network_address_assign_type`, `node_network_name_assign_type`, `node_network_device_id`. \|

	\|useNetlink\|bool\|A Boolean flag that activates the netlink implementation of the `netclass` collector. This improves performance of `netclass` collector while omitting these metrics: `node_network_address_assign_type`, `node_network_name_assign_type`, `node_network_device_id`.
	\|useNetlink\|bool\|A Boolean flag that activates the `netlink` implementation of the `netclass` collector. This implementation improves the performance of the `netclass` collector by omitting these metrics: `node_network_address_assign_type`, `node_network_name_assign_type`, `node_network_device_id`.

	// A Boolean flag that activates the netlink implementation of the `netclass` collector.
	// A Boolean flag that activates the `netlink` implementation of the `netclass` collector.

	// This improves performance of `netclass` collector while omitting these metrics:
	// This implementation improves the performance of the `netclass` collector by omitting these metrics:

MON-2895: toggle netlink implementation of netclass collector #1894

MON-2895: toggle netlink implementation of netclass collector #1894

Conversation

raptorsun commented Feb 15, 2023

openshift-ci-robot commented Feb 15, 2023 • edited by openshift-ci bot Loading

raptorsun commented Feb 15, 2023

raptorsun commented Feb 16, 2023

raptorsun commented Feb 16, 2023

raptorsun commented Feb 17, 2023

raptorsun commented Feb 17, 2023

raptorsun commented Feb 22, 2023

raptorsun commented Feb 23, 2023

simonpasquier left a comment

Choose a reason for hiding this comment

Senthamilarasu-STA commented Feb 27, 2023

raptorsun commented Feb 27, 2023

raptorsun commented Feb 27, 2023

Tai-RedHat commented Feb 28, 2023

bburt-rh Feb 28, 2023 • edited Loading

Choose a reason for hiding this comment

bburt-rh Feb 28, 2023 • edited Loading

Choose a reason for hiding this comment

bburt-rh Feb 28, 2023

Choose a reason for hiding this comment

bburt-rh Feb 28, 2023 • edited Loading

Choose a reason for hiding this comment

bburt-rh commented Feb 28, 2023

raptorsun commented Feb 28, 2023

bburt-rh commented Feb 28, 2023

raptorsun commented Feb 28, 2023

openshift-ci bot commented Feb 28, 2023

JoaoBraveCoding left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Mar 1, 2023

openshift-ci-robot commented Feb 15, 2023 •

edited by openshift-ci bot

Loading

bburt-rh Feb 28, 2023 •

edited

Loading

bburt-rh Feb 28, 2023 •

edited

Loading

bburt-rh Feb 28, 2023 •

edited

Loading