Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

STOR-2141: add enhancement for vSphere configurable max number of volumes per node #1748

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

STOR-2141: add enhancement for vSphere configurable max number of volumes per node #1748

wants to merge 1 commit into from

Conversation

RomanBednar
Copy link
Contributor

@RomanBednar RomanBednar commented Jan 31, 2025 •
edited
Loading

openshift/api PR: openshift/api#2190

cc @openshift/storage

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 31, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 31, 2025 •
edited by openshift-ci bot
Loading

@RomanBednar: This pull request references STOR-2141 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign miciah for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RomanBednar RomanBednar changed the title STOR-2141: add enhancement for vSphere configurable max number of volumes per node WIP: STOR-2141: add enhancement for vSphere configurable max number of volumes per node Jan 31, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2025
@RomanBednar RomanBednar changed the title WIP: STOR-2141: add enhancement for vSphere configurable max number of volumes per node STOR-2141: add enhancement for vSphere configurable max number of volumes per node Feb 3, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 3, 2025 •
edited by openshift-ci bot
Loading

@RomanBednar: This pull request references STOR-2141 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.19.0" version, but no target version was set.

In response to this:

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 3, 2025 •
edited by openshift-ci bot
Loading

@RomanBednar: This pull request references STOR-2141 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.19.0" version, but no target version was set.

In response to this:

openshift/api PR: openshift/api#2190

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@RomanBednar
Copy link
Contributor Author

/assign @gnufied

For review, feel free to reassign to someone else if needed.

gnufied
gnufied reviewed Feb 5, 2025
View reviewed changes
enhancements/storage/vsphere-configurable-maximum-allowed-number-of-block-volumes-per-node.md Outdated
- Enabling FSS without checking vSphere and ESXi versions poses a risk because cluster can have different versions of
ESXi per host. If higher limit is enabled CSI driver reports this limit that is later checked by pod scheduler. The
scheduler might assign a pod to a node that can be already at its limit due to ESXi limitations, failing all
volume attachments.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this feature-gate is already enabled in driver now and there is no way to disable/enable it. This is called a released feature now - https://github.com/openshift/vmware-vsphere-csi-driver/blob/master/pkg/csi/service/common/commonco/k8sorchestrator/k8sorchestrator.go#L354

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, I've updated the enhancement to reflect this.

gnufied
gnufied reviewed Feb 5, 2025
View reviewed changes
enhancements/storage/vsphere-configurable-maximum-allowed-number-of-block-volumes-per-node.md Outdated

### Risks and Mitigations

1. Unlimited volume attachments per node:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also block users from setting this value to 0 via some kind of validation in CRD.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely, more on this in API PR: openshift/api#2190 (comment)

@RomanBednar RomanBednar mentioned this pull request Feb 6, 2025
Open
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 6, 2025

@RomanBednar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@RomanBednar
Copy link
Contributor Author

@jsafrane I've updated the enhancement, but we're still at a point where we don't have any usable docs from vmware so I pointed that out as well here.

jsafrane
jsafrane reviewed Mar 13, 2025
View reviewed changes
enhancements/storage/vsphere-configurable-maximum-allowed-number-of-block-volumes-per-node.md

### Drawbacks

- Increased Complexity: Introducing a new CRD and operator logic adds complexity to the vSphere CSI driver ecosystem.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no new CRD, I hope.

Suggested change
- Increased Complexity: Introducing a new CRD and operator logic adds complexity to the vSphere CSI driver ecosystem.
- Increased Complexity: Introducing a new CRD field and operator logic adds complexity to the vSphere CSI driver ecosystem.

enhancements/storage/vsphere-configurable-maximum-allowed-number-of-block-volumes-per-node.md
- **Upgrades:** During an upgrade, the operator will apply the new API field value and update the driver DaemonSet with
the new `MAX_VOLUMES_PER_NODE` value. If the field is not set, default value (59) is used to match the current limit
for vSphere 7. So the limit will not change for existing deployments.
-**Downgrades:** Downgrading to a version without this feature will result in the API field being ignored and the
Copy link
Contributor

@jsafrane jsafrane Mar 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This did not render well, needs an extra space:

Suggested change
-**Downgrades:** Downgrading to a version without this feature will result in the API field being ignored and the
- **Downgrades:** Downgrading to a version without this feature will result in the API field being ignored and the

enhancements/storage/vsphere-configurable-maximum-allowed-number-of-block-volumes-per-node.md

- E2E test coverage demonstrating stability.
- Available by default.
- User facing documentation created in [openshift-docs](https://github.com/openshift/openshift-docs/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention that we want to wait for VMware to document the configuration on vCenter side?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@gnufied gnufied gnufied left review comments

@jsafrane jsafrane jsafrane left review comments

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@gnufied gnufied

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RomanBednar @openshift-ci-robot @gnufied @jsafrane