Add initial enhancement templates #2

derekwaynecarr · 2019-08-23T19:15:14Z

Add initial enhancement template and repo content.

deads2k · 2019-08-23T19:49:38Z

README.md

+
+## Is My Thing an Enhancement?
+
+A rough heuristic for an enhancement is anything that:


I think that anything with upgrade/downgrade impacts deserves an enhancement.

sgtm, will update.

deads2k · 2019-08-23T19:50:38Z

README.md

+If you are not sure if the proposed work requires an enhancement, file an issue
+and ask!
+
+## When to Create a New Enhancement Issue


issue or PR?

deads2k · 2019-08-23T19:50:53Z

README.md

+Create an issue here once you:
+
+- have circulated your idea to see if there is interest
+   - through Community Meetings, SIG meetings, or mailing lists


we don't have community meetings or sig meetings.

some groups do, but I am going to omit this for the moment, and we can have a place on how to reach out across mailing lists, slack, etc.

deads2k · 2019-08-23T19:51:16Z

README.md

+- have circulated your idea to see if there is interest
+   - through Community Meetings, SIG meetings, or mailing lists
+- (optionally) have done a prototype in your own fork
+- have identified people who agree to work on the enhancement


work on and maintain

deads2k · 2019-08-23T19:53:14Z

enhancements/README.md

+
+## Quick start
+
+1. Socialize an idea with others.  Make sure others thing the work is worth


s/thing/think

deads2k · 2019-08-23T19:54:01Z

enhancements/README.md

+
+### Do I put de# a particular directory?
+
+If it has broad impact, place it in the root of this directory.  If its


deads2k · 2019-08-23T19:54:43Z

enhancements/enhancements-template.md

+  - "/enhancements/our-past-effort.md"
+---
+
+# Title


this one can be title cased, right?

i don't understand this comment.

deads2k · 2019-08-23T19:54:52Z

enhancements/enhancements-template.md

@@ -0,0 +1,223 @@
+---
+title: Enhancement Template


and this is the dash delimited one.

deads2k · 2019-08-23T19:56:31Z

enhancements/enhancements-template.md

+   logical description for the deployment, and how it handles the unique aspects
+   of the platform. Aim for single topic PRs to keep discussions focused. If you
+   disagree with what is already in a document, open a new PR with suggested
+   changes.


Only merge pieces of the doc that we agree with. Not attempts that you do not agree with. Otherwise these get really confusing to read.

deads2k · 2019-08-23T19:58:14Z

enhancements/enhancements-template.md

+
+### Version Skew Strategy
+
+If applicable, how will the component handle version skew with other components?


We will always have skew. During an upgrade, two versions will be present with no guaranteed order.

jeremyeder · 2019-08-27T20:16:14Z

Want to submit an enhancement in the next sprint or 2. Just checking to see when this will be finalized and merged.

derekwaynecarr · 2019-08-27T20:52:52Z

You can submit an enhancement at any time. I would like to merge and iterate on this.

derekwaynecarr · 2019-08-27T21:14:24Z

@deads2k i made majority of updates noted, would like to merge and iterate on this after.

Update Proposal Method 2 for Day1 kargs

The broken link is from 881dbb7 (Add initial enhancement templates, 2019-08-23, openshift#2), with a sloppy copy from [1]. I'm fixing with a verbatim copy from the KEP template (and dropping template-only stuff from the user-workload-monitoring enhancement). This is a bit of a semantic change from what we had previously. The OpenShift vs. Kubernetes maturity levels are not clear to me. OpenShift does have docs on GA and later [2], and we do have docs on using Technology Preview features [3], but I have not turned up docs for what Technology preview means in terms of maturity/support. But even if there is a Kubernetes / OpenShift maturity distinction, OpenShift is going to expose Kubernetes features before they go stable. And we use v1beta1 and whatnot for OpenShift configs. So I don't think we can drop the Kubernetes maturity references altogether, although we can add OpenShift maturity references in addition (once we find out what to reference). [1]: https://github.com/kubernetes/enhancements/blame/f1a799d5f4658ed29797c1fb9ceb7a4d0f538e93/keps/YYYYMMDD-kep-template.md#L216-L221 [2]: https://access.redhat.com/support/policy/updates/openshift/ [3]: https://docs.openshift.com/container-platform/4.2/nodes/clusters/nodes-cluster-enabling-features.html#nodes-cluster-features-about_nodes-cluster-enabling

wking · 2019-11-14T23:17:28Z

enhancements/enhancements-template.md

+#### Examples
+
+These are generalized examples to consider, in addition to the aforementioned
+[maturity levels][maturity-levels].


I've taken a stab at fixing this broken link in #114.

The bracketed openshift/docs is from 881dbb7 (Add initial enhancement templates, 2019-08-23, openshift#2). But a link makes it easy for folks to see where changes should go, and is something that can be updated by enhancements to link specific PRs as they check off this box.

OLM approach proposal

The broken link is from 881dbb7 (Add initial enhancement templates, 2019-08-23, openshift#2), with a sloppy copy from [1]. I'm fixing with a verbatim copy from the KEP template (and dropping template-only stuff from the user-workload-monitoring enhancement). This is a bit of a semantic change from what we had previously. The OpenShift vs. Kubernetes maturity levels are not clear to me. OpenShift does have docs on GA and later [2], and we do have docs on using Technology Preview features [3], but I have not turned up docs for what Technology preview means in terms of maturity/support. But even if there is a Kubernetes / OpenShift maturity distinction, OpenShift is going to expose Kubernetes features before they go stable. And we use v1beta1 and whatnot for OpenShift configs. So I don't think we can drop the Kubernetes maturity references altogether, although we can add OpenShift maturity references in addition (once we find out what to reference). I also went through existing enhancements and removed useless copies of the template boilerplate, to make it more clear that those particular enhancements did not have anything to say about graduation criteria. [1]: https://github.com/kubernetes/enhancements/blame/f1a799d5f4658ed29797c1fb9ceb7a4d0f538e93/keps/YYYYMMDD-kep-template.md#L216-L221 [2]: https://access.redhat.com/support/policy/updates/openshift/ [3]: https://docs.openshift.com/container-platform/4.2/nodes/clusters/nodes-cluster-enabling-features.html#nodes-cluster-features-about_nodes-cluster-enabling

Fedosin's changes 2

Single node should run OLM and MCO

Refocus on ovn-k/cno work only

…lel-meta.md cosa/20200805-meta-merge: design for merged meta.json

Enhancement proposal for the API evolution of APIExport in relation t…

Address review comments

OCPEDGE-1344: Updated details of installation and unanswered questions.

openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 23, 2019

openshift-ci-robot requested review from ecordell and sdodson August 23, 2019 19:15

deads2k reviewed Aug 23, 2019

View reviewed changes

Add initial enhancement templates

881dbb7

derekwaynecarr force-pushed the templates branch from 3c3c0b1 to 881dbb7 Compare August 27, 2019 21:11

deads2k merged commit 3d72a4f into openshift:master Aug 29, 2019

openshift-merge-robot pushed a commit that referenced this pull request Oct 24, 2019

Merge pull request #2 from sinnykumari/PROD-1552/GroupA/MCO/kargs-day-1

d3ef24d

Update Proposal Method 2 for Day1 kargs

wking mentioned this pull request Nov 14, 2019

enhancements/template: Fix maturity-levels link #114

Merged

wking reviewed Nov 14, 2019

View reviewed changes

wking mentioned this pull request Nov 15, 2019

enhancements/template: Fix openshift-docs links #116

Merged

marun added a commit to marun/enhancements that referenced this pull request Jan 14, 2020

Fixup openshift#2

5b67fb2

marun added a commit to marun/enhancements that referenced this pull request Feb 4, 2020

Fixup openshift#2

1234397

marun mentioned this pull request Feb 4, 2020

service-ca-rotation: Ensure pod restart before expiry of pre-rotation CA #193

Merged

pedjak pushed a commit to pedjak/openshift-enhancements that referenced this pull request Mar 30, 2020

Merge pull request openshift#2 from sbose78/sbose78-patch-1

9660c22

OLM approach proposal

deads2k mentioned this pull request Aug 7, 2020

describe e2e observer pods #425

Merged

jottofar mentioned this pull request Sep 10, 2020

Enhancement for adding a manifest annotation for object removal #419

Merged

JoelSpeed pushed a commit to JoelSpeed/enhancements that referenced this pull request Oct 15, 2020

Merge pull request openshift#2 from Fedosin/out-of-tree-2

99f99aa

Fedosin's changes 2

eranco74 referenced this pull request in eranco74/enhancements Oct 29, 2020

Merge pull request #2 from eranco74/single_node_edge

884ef1c

Single node should run OLM and MCO

stlaz added a commit to stlaz/enhancements that referenced this pull request Oct 30, 2020

address comments openshift#2, add defaul table view

77b575c

sferich888 mentioned this pull request Dec 18, 2020

baremetal: Propose BMC-less remediation enhancement (AKA poison pill) #547

Closed

russellb mentioned this pull request May 10, 2021

metallb: Update operator, CRD, and BGP stack plans #772

Merged

marun added a commit to marun/enhancements that referenced this pull request Jul 16, 2021

Fixup openshift#2

e7baf28

raffaelespazzoli mentioned this pull request Sep 22, 2021

Cloud API component for egress IP #571

Merged

candita mentioned this pull request Sep 27, 2021

ingress: Add mutable-publishing-scope enhancement #876

Merged

jotak referenced this pull request in jotak/openshift-enhancements Oct 14, 2021

Merge pull request #2 from jotak/ovs-flow-export-configuration

fcc619d

Refocus on ovn-k/cno work only

cgwalters pushed a commit to cgwalters/enhancements that referenced this pull request Oct 19, 2021

Merge pull request openshift#2 from darkmuggle/pr/cosa/20200805-paral…

a87e95a

…lel-meta.md cosa/20200805-meta-merge: design for merged meta.json

bertinatto mentioned this pull request Dec 1, 2022

Improved platform tests #1291

Merged

stevekuznetsov pushed a commit to stevekuznetsov/enhancements that referenced this pull request Apr 3, 2023

Merge pull request openshift#2 from fgiloux/apiexport-shard-endpoints

3a0ff65

Enhancement proposal for the API evolution of APIExport in relation t…

OlivierCazade pushed a commit to OlivierCazade/openshift-enhancements that referenced this pull request Nov 17, 2023

Merge pull request openshift#2 from OlivierCazade/ingress-rw

f35df4a

Address review comments

jewzaam mentioned this pull request Mar 1, 2024

Add Change Management and Maintenance Schedules #1571

Open

ShaunaDiaz mentioned this pull request Oct 2, 2024

USHIFT-4377: introduce microshift ingress performance enhancement #1685

Merged

jupierce mentioned this pull request Oct 11, 2024

Split RHCOS into layers #1637

Merged

beekhof mentioned this pull request Oct 12, 2024

Two nodes openshift #1675

Open

jupierce mentioned this pull request Oct 14, 2024

WIP: OpenShift Tests Extension Framework Initial #1676

Open

jaypoulz pushed a commit to jaypoulz/enhancements that referenced this pull request Dec 3, 2024

Merge pull request openshift#2 from jaypoulz/2no

00a357f

OCPEDGE-1344: Updated details of installation and unanswered questions.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add initial enhancement templates #2

Add initial enhancement templates #2

derekwaynecarr commented Aug 23, 2019 •

edited

Loading

deads2k Aug 23, 2019

derekwaynecarr Aug 27, 2019

deads2k Aug 23, 2019

deads2k Aug 23, 2019

derekwaynecarr Aug 27, 2019

deads2k Aug 23, 2019

deads2k Aug 23, 2019

deads2k Aug 23, 2019

deads2k Aug 23, 2019

derekwaynecarr Aug 27, 2019

deads2k Aug 23, 2019

deads2k Aug 23, 2019

deads2k Aug 23, 2019

jeremyeder commented Aug 27, 2019

derekwaynecarr commented Aug 27, 2019

derekwaynecarr commented Aug 27, 2019

wking Nov 14, 2019


		## Is My Thing an Enhancement?

		A rough heuristic for an enhancement is anything that:


		## Quick start

		1. Socialize an idea with others. Make sure others thing the work is worth


		### Do I put de# a particular directory?

		If it has broad impact, place it in the root of this directory. If its


		### Version Skew Strategy

		If applicable, how will the component handle version skew with other components?

Add initial enhancement templates #2

Add initial enhancement templates #2

Conversation

derekwaynecarr commented Aug 23, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jeremyeder commented Aug 27, 2019

derekwaynecarr commented Aug 27, 2019

derekwaynecarr commented Aug 27, 2019

Choose a reason for hiding this comment

derekwaynecarr commented Aug 23, 2019 •

edited

Loading