HIVE-2558: Drop codegen k8s.io/code-generator

[celebdor]

generate-groups.sh was deprecated in k8s.io/code-generator 1.29 and deleted in 1.30. Instead, the usage was replaced with:

• kube_codegen.sh library's kube::codegen::gen_helpers

The issue with the above is:

• It doesn't allow to specify just running deepcopy and instead adds as well code conversion and defaulter code generation.
• While deepcopy-gen and conversion-gen can deal well with the multiple input paths that we have, conversion-gen wants to work at the package level, which means it ends up wrongly processing the vendored k8s deepcopy directives. This in turn means that we are forced to use the kubernetes header files to respect their copyright, but ends up adding the kubernetes copyright to openshift generated code.
• gen_helpers enforces usage of --output-base matching the import name, which means that we had to workaround with a symlink of ${REPO_ROOT}/github.com/openshift/ to "${REPO_ROOT}..".
• vendored generated deepcopy got deleted and make vendor had to pick up the tab.

[openshift-ci-robot]

@celebdor: This pull request references HIVE-2558 which is a valid jira issue.

In response to this:

generate-groups.sh was deprecated in k8s.io/code-generator 1.29 and deleted in 1.30. Instead, the usage was replaced with:

• kube_codegen.sh library's kube::codegen::gen_helpers

The issue with the above is:

• It doesn't allow to specify just running deepcopy and instead adds as well code conversion and defaulter code generation.
• While deepcopy-gen and conversion-gen can deal well with the multiple input paths that we have, conversion-gen wants to work at the package level, which means it ends up wrongly processing the vendored k8s deepcopy directives. This in turn means that we are forced to use the kubernetes header files to respect their copyright, but ends up adding the kubernetes copyright to openshift generated code.
• gen_helpers enforces usage of --output-base matching the import name, which means that we had to workaround with a symlink of ${REPO_ROOT}/github.com/openshift/ to "${REPO_ROOT}..".
• vendored generated deepcopy got deleted and make vendor had to pick up the tab.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: celebdor
Once this PR has been reviewed and has the lgtm label, please assign 2uasimojo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@celebdor: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/periodic-images	b60141f	link	true	/test periodic-images
ci/prow/security	b60141f	link	true	/test security
ci/prow/verify	b60141f	link	true	/test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[2uasimojo]

I ran into the same failure with go install <web URI> in #2481

Can we try:

• Make sure we have code-generator vendored at the appropriate version in go.mod, and naked-imported in pkg/dependencymagnet/go.doc
• Use go install $(shell realpath vendor/k8s.io/code-generator/cmd/deepcopy-gen) here to build the tool from the vendor dir

?

[2uasimojo]

/remove-lifecycle stale

@celebdor lmk if you want me to pick this up.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[2uasimojo]

Looking at the current tip of master, this seems to have already been done elsewhere.