HIVE-2656: Various fixes related to hive developer experience (dx) #2512
Conversation
|
/retitle HIVE-2656: Various fixes related to hive developer experience (dx) |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@dlom: This pull request references HIVE-2656 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@dlom: This pull request references HIVE-2656 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1 similar comment
|
@dlom: This pull request references HIVE-2656 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
.gitignore: add venv so I stop accidentally adding it with `git add hack/` hack/*.sh: use `oc` instead of `kubectl` Makefile: add target for using podman to push to registry (local registry running in podman has no security setup, hence ignore TLS)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@dlom: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| @@ -317,6 +317,10 @@ buildah-dev-build: | |||
| podman-dev-build: | |||
| podman build --tag ${IMG} $(GOCACHE_VOL_ARG) -f ./Dockerfile . | |||
|
|
|||
| .PHONY: podman-dev-push | |||
| podman-dev-push: podman-dev-build | |||
| podman push --tls-verify=false ${IMG} | |||
There was a problem hiding this comment.
Definitely +1 to having this target.
I don't think we should turn off TLS by default though. Other options:
- Make a
PODMAN_PUSH_FLAGSvar so you canmake PODMAN_PUSH_FLAGS=--tls-verify=false podman-dev-pushwhen your registry is "insecure" (or whatever). - Configure your personal insecure registries per the man page:
If not specified, TLS verification is used unless the target registry is listed as an insecure registry in containers-registries.conf(5)
| @@ -7,6 +7,7 @@ | |||
| bin/** | |||
| **/__debug_bin | |||
| **/__pycache__ | |||
| **/venv | |||
There was a problem hiding this comment.
I don't hate this, but it assumes everyone uses the same name for their python venv as you.
You can set up personal gitignores in several ways. For example, my ~/.gitconfig contains:
[core]
excludesfile = /home/efried/.gitignore
...and that file contains:
.vscode/
*.orig
.sw[a-p]
.*.sw[a-p]
(The idea being that not everyone necessarily uses vscode -- though I see we've got that in here on L33 -- or vim.)
| @@ -5,7 +5,7 @@ | |||
| # - hiveadmission | |||
| # - hive-controllers | |||
| # | |||
| cat <<EOF | kubectl apply -f - | |||
| cat <<EOF | oc apply -f - | |||
There was a problem hiding this comment.
-1
This script is explicitly for folks setting up hive on non-openshifts.
And most of the time, people have them (sym)linked to each other anyway.
efried@efried-thinkpadp16vgen1:~/go/src/github.com/openshift/hive$ ll -i ~/bin/oc ~/bin/kubectl
2567104 -rwxr-xr-x. 2 efried efried 160441224 Jul 18 16:42 /home/efried/bin/kubectl*
2567104 -rwxr-xr-x. 2 efried efried 160441224 Jul 18 16:42 /home/efried/bin/oc*
| @@ -24,7 +24,7 @@ cat <<EOF | cfssl genkey - | cfssljson -bare server | |||
| } | |||
| EOF | |||
|
|
|||
| cat <<EOF | kubectl apply -f - | |||
| cat <<EOF | oc apply -f - | |||
.gitignore: add venv so I stop accidentally adding it withgit add hack/hack/*.sh: useocinstead ofkubectlMakefile: add target for using podman to push to registry (local registry running in podman has no security setup, hence ignore TLS)/assign @2uasimojo
card: HIVE-2656