ClusterSync: Warn on resource conflicts #2521
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new ClusterSync.Status field, ResourceConflicts, and a
corresponding printColumn visible when `-o wide` is used.
When a single resource (GVK + name [+ namespace if ns-scoped]) is
mentioned more than once in the `resources` sections (not `patches` or
`secretMappings`) of the [Selector]SyncSets matching a
ClusterDeployment, we will add a human-readable message to this status
field indicating the resource and the [Selector]SyncSets in which it is
mentioned.
Example message:
```
"Resource {v1 Namespace openshift-logging } is mentioned by 2 [Selector]SyncSets: mygroup, osd-logging1"
```
HIVE-2634
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new ClusterSync.Status field, ResourceConflicts, and a corresponding printColumn visible when
-o wideis used.When a single resource (GVK + name [+ namespace if ns-scoped]) is mentioned more than once in the
resourcessections (notpatchesorsecretMappings) of the [Selector]SyncSets matching a ClusterDeployment, we will add a human-readable message to this status field indicating the resource and the [Selector]SyncSets in which it is mentioned.Example message:
HIVE-2634