Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

OLS-670: readiness probe checks cache state #2148

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

raptorsun
Copy link
Contributor

@raptorsun raptorsun commented Jan 14, 2025

Description

readiness probe checks cache state

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 14, 2025

@raptorsun: This pull request references OLS-670 which is a valid jira issue.

In response to this:

Description

readiness probe checks cache state

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@raptorsun
Copy link
Contributor Author

/hold
still testing

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 14, 2025

@raptorsun: This pull request references OLS-670 which is a valid jira issue.

In response to this:

Description

readiness probe checks cache state

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2025
@openshift-ci openshift-ci bot requested review from bparees and xrajesh January 14, 2025 14:59
Copy link

openshift-ci bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.90%. Comparing base (e53e0c2) to head (e5d1305).
Report is 40 commits behind head on main.

Files with missing lines Patch % Lines
ols/app/endpoints/health.py 66.66% 2 Missing ⚠️
ols/src/cache/redis_cache.py 87.50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2148      +/-   ##
==========================================
- Coverage   96.99%   96.90%   -0.10%     
==========================================
  Files          72       73       +1     
  Lines        2930     3068     +138     
==========================================
+ Hits         2842     2973     +131     
- Misses         88       95       +7     
Files with missing lines Coverage Δ
ols/src/cache/cache.py 100.00% <100.00%> (ø)
ols/src/cache/in_memory_cache.py 97.87% <100.00%> (+0.09%) ⬆️
ols/src/cache/postgres_cache.py 95.50% <100.00%> (+0.38%) ⬆️
ols/src/cache/redis_cache.py 98.33% <87.50%> (-1.67%) ⬇️
ols/app/endpoints/health.py 96.00% <66.66%> (-4.00%) ⬇️

... and 10 files with indirect coverage changes

@raptorsun raptorsun force-pushed the cache-readiness branch 2 times, most recently from 9ceb85d to 9e708df Compare January 15, 2025 10:26
Signed-off-by: Haoyu Sun <hasun@redhat.com>
Copy link

openshift-ci bot commented Jan 15, 2025

@raptorsun: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify e5d1305 link true /test verify
ci/prow/images e5d1305 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants