Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Release trustee-operator in OCP 4.17 #39

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

lmilleri
Copy link
Contributor

No description provided.

Copy link
Contributor

@spotlesstofu spotlesstofu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The application name should be trustee-fbc-4-17, not trustee-fbc. I pointed out one occurrence, but there are several.

- name: revision
value: '{{revision}}'
- name: output-image
value: quay.io/redhat-user-workloads/ose-osc-tenant/trustee-fbc/trustee-fbc-4-17:on-pr-{{revision}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
value: quay.io/redhat-user-workloads/ose-osc-tenant/trustee-fbc/trustee-fbc-4-17:on-pr-{{revision}}
value: quay.io/redhat-user-workloads/ose-osc-tenant/trustee-fbc-4-17/trustee-fbc-4-17:on-pr-{{revision}}

@lmilleri lmilleri force-pushed the ocp4.17 branch 6 times, most recently from 271695b to bebd64e Compare November 4, 2024 12:47
Signed-off-by: Leonardo Milleri <lmilleri@redhat.com>
- name: revision
value: '{{revision}}'
- name: output-image
value: quay.io/redhat-user-workloads/ose-osc-tenant/trustee-fbc-4-17:on-pr-{{revision}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned off-channel, this is not the standard URL, but it works and I'm OK with it.

@spotlesstofu spotlesstofu merged commit 21b774e into openshift:main Nov 4, 2024
2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants