Onboard Sentry

[chadwhitacre]

No description provided.

[vladh]

@chadwhitacre The JSON file is missing datetimeModified, which makes checking for new changes impossible — could we add it?

[chadwhitacre]

Ah, I was expecting that we would add that on our side. Wdyt?

[vladh]

Hmm, so the problem we want to solve here is: detecting when a member has changed their JSON file.

Either way we have to: fetch from the JSON file URL periodically.

To detect changes, we can either:

1. check if datetimeModified is newer, or
2. check if the JSON is different from what we have locally.

The code currently does (1). If you'd like to do (2), I can change the code to do that, and we can remove datetimeModified.

I would personally do (1) and keep datetimeModified, because without it, while we can check that a member's JSON file is different, we can't know that it's newer. But, (2) is probably also Good Enough™.

[chadwhitacre]

Or should we just drop datetimeModified entirely? Does it matter? How are we going to use it?

I think my thought in adding it originally is that we could use it to implement a more complex algorithm for fetching JSON files, something like: check datetimeModified and if it's recent don't refetch for a month or whatever. That now seems like overcomplication to me and probably we can just drop/ignore it entirely. Eh?

[chadwhitacre]

Seeing how we're currently using it:

https://github.com/opensourcepledge/osspledge.com/blob/c6dc6b5e5682019838592006d2980ba6c3520b91/bin/update-member#L38-L42

Since this doesn't save us from the fetch, it seems we could probably just always save the file contents and let git do the work of picking up changes.

[vladh]

Cool, let's just assume changed=newer and drop datetimeModified entirely, I'll prepare a PR, then I'll merge this!

[chadwhitacre]

#55 :)

[vladh]

That was speedy!

[vladh]

Tested and LGTM, merging.

[vladh]

We forgot to rename paymentsToProjects to payments, did that on main in 33a42fc.

[vladh]

Also should have removed domain, done in dcda264 — it was unused anyway.

[vladh]

I also made a few improvements to deploy.yml on main.

Deployment done, LGTM! https://osspledge.com/members/sentry/

[chadwhitacre]

👍 🎉