Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[loginrec.c] Fix "undeclared 'ut'" error by replacing it with 'utx' #490

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pmiadzvedzeu
Copy link
Contributor

In the utmpx_perform_login function there are no ut declarations, but there is utx. I believe this mistake was made during copy-paste from utmp_perform_login function where ut is used.

@pmiadzvedzeu
Copy link
Contributor Author

pmiadzvedzeu commented Apr 24, 2024

Hello, @daztucker, @djmdjm
All of the 32 failed checks (for now) show a CI setup error. I don't think it's my fault. Could you please check this?

@daztucker
Copy link
Contributor

daztucker commented Apr 25, 2024

Hello, @daztucker, @djmdjm All of the 32 failed checks (for now) show a CI setup error. I don't think it's my fault. Could you please check this?

Yep that's not you. It looks like Github have managed to break either their ubuntu-latest package repo, or update the ubuntu-latest image to point to a different broken repo. My guess is the latter, since the unbuntu-22.04 image seems unaffected.

E: Failed to fetch https://packages.microsoft.com/ubuntu/22.04/prod/dists/jammy/InRelease Clearsigned file isn't valid, got 'NOSPLIT' (does the network require authentication?)
E: The repository 'https://packages.microsoft.com/ubuntu/22.04/prod jammy InRelease' is no longer signed.

Back to the PR: which platform(s) and/or configure options did you observe the error on?

@daztucker
Copy link
Contributor

It looks like Github have managed to break either their ubuntu-latest package repo

and from more recent runs it looks like they've since fixed it, so I've rerun the failed tests.

The openssl-master test failure is on us, OpenSSL moved to 3.4 and configure did not accept that. I've just committed a change to configure that should fix that, so if you pull in those changes you should get a clean test run.

@kalvdans
Copy link

kalvdans commented May 2, 2024

Could you change the #ifdef's to normal C code: if (UTMPX_USE_LIBRARY) instead? Then both code paths will be syntax checked no matter what it is defined to.

@djmdjm
Copy link
Contributor

djmdjm commented Oct 18, 2024

I've merged this because the previous code was clearly wrong, but Darren's question is still standing:

Back to the PR: which platform(s) and/or configure options did you observe the error on?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants