-
-
Notifications
You must be signed in to change notification settings - Fork 74
Conversation
If a new target doesn't modify the C sources and is considered low risk, it can be added to LTS releases.
Assembler? |
Deliberately not mentioned: it falls under the "low risk" part. A new assembler file just for the platform would be something I consider low risk. Modifying an existing assembler file would be less clear. I've no objection to adding assembler if others think it worthwhile. |
I'm satisfied that it has been thought of |
This seems different to what we have previously talked about (LTS+). Is this idea instead of LTS+, or do you still see a place for that idea? |
I see this as in addition to LTS+. LTS+ would allow code changes for new platforms e.g. I'm really just thinking about a way to approve PRs like openssl/openssl#14724 without votes. |
I don't have a view on whether assembler changes are in-scope, but I think this discussion shows that there is new code (such as for risc-v some day?) and modifying existing code (the recent ARM changes), and the policy should cover that. Not necessarily with explicit statements, but a general thought. |
I would not have put "C" in the description - this is an easy thing if there are no code modifications. |
I've removed the C from the text. |
"the required changes do not modify the source code" is still somewhat vague if you ask me. What exactly qualifies as source code? Is a .info file source code? What about a ".conf" file? What about a ".tmpl"? |
I guess you can turn it into: "is acceptable so long as the required changes are deemed low risk by the OTC" |
At which point you can argue that assembler changes from 1 branch to an other are also low risk ... |
@kroeckx, I was thinking along similar lines originally. |
Failing vote closed in anticipation of further discussions about what is and what is not allowed. |
If a new target doesn't modify the C sources and is considered low risk, it can be added to LTS releases.
This will require an OMC vote but it is being raised here for discussion.