Skip to content
This repository was archived by the owner on Aug 29, 2024. It is now read-only.

platform policy: add new targets #240

Closed
wants to merge 2 commits into from

Conversation

paulidale
Copy link
Contributor

If a new target doesn't modify the C sources and is considered low risk, it can be added to LTS releases.

This will require an OMC vote but it is being raised here for discussion.

If a new target doesn't modify the C sources and is considered low risk, it
can be added to LTS releases.
@paulidale paulidale self-assigned this May 28, 2021
@levitte
Copy link
Member

levitte commented May 28, 2021

Assembler?

@paulidale
Copy link
Contributor Author

paulidale commented May 28, 2021

Deliberately not mentioned: it falls under the "low risk" part.

A new assembler file just for the platform would be something I consider low risk. Modifying an existing assembler file would be less clear.

I've no objection to adding assembler if others think it worthwhile.

@levitte
Copy link
Member

levitte commented May 28, 2021

I'm satisfied that it has been thought of

@mattcaswell
Copy link
Member

This seems different to what we have previously talked about (LTS+). Is this idea instead of LTS+, or do you still see a place for that idea?

@paulidale
Copy link
Contributor Author

I see this as in addition to LTS+. LTS+ would allow code changes for new platforms e.g.

I'm really just thinking about a way to approve PRs like openssl/openssl#14724 without votes.

@richsalz
Copy link
Contributor

I don't have a view on whether assembler changes are in-scope, but I think this discussion shows that there is new code (such as for risc-v some day?) and modifying existing code (the recent ARM changes), and the policy should cover that. Not necessarily with explicit statements, but a general thought.

@t-j-h
Copy link
Member

t-j-h commented Jun 1, 2021

I would not have put "C" in the description - this is an easy thing if there are no code modifications.
But with code modifications (assembler) being allowed it is a lot less safe as it is basically adding new implementation logic rather than just compiling the same code on another platform. i.e. this went beyond build flags.

@paulidale
Copy link
Contributor Author

I've removed the C from the text.

@mattcaswell
Copy link
Member

"the required changes do not modify the source code" is still somewhat vague if you ask me. What exactly qualifies as source code? Is a .info file source code? What about a ".conf" file? What about a ".tmpl"?

@kroeckx
Copy link
Member

kroeckx commented Jun 1, 2021

I guess you can turn it into: "is acceptable so long as the required changes are deemed low risk by the OTC"

@kroeckx
Copy link
Member

kroeckx commented Jun 1, 2021

At which point you can argue that assembler changes from 1 branch to an other are also low risk ...

@paulidale
Copy link
Contributor Author

@kroeckx, I was thinking along similar lines originally.

@paulidale
Copy link
Contributor Author

Failing vote closed in anticipation of further discussions about what is and what is not allowed.

@paulidale paulidale closed this Jun 2, 2021
@paulidale paulidale deleted the new-platforms branch January 10, 2022 01:09
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants