Tls tidy #498
Tls tidy #498
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshephar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6f759dda1e054e68b596298a8ac875c9 ✔️ openstack-k8s-operators-content-provider SUCCESS in 21m 43s |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/13570bf914964cd084a67be97521f50a ❌ openstack-k8s-operators-content-provider FAILURE in 14m 08s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/70f9b8bac7334123b1aff994d0cad453 ❌ openstack-k8s-operators-content-provider FAILURE in 15m 50s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5395d5cca45c40dbac3b7b906e9b7b3e ❌ openstack-k8s-operators-content-provider FAILURE in 15m 53s |
|
@bshephar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This change splits out the volume and mounts logic into dedicated functions This ultimately makes the deployment logic more legible and easier to test. Signed-off-by: Brendan Shephard <bshephar@redhat.com>
| @@ -159,3 +137,58 @@ func Deployment( | |||
| } | |||
| return deployment, nil | |||
| } | |||
|
|
|||
| func createVolumeAndMounts(instance *heatv1beta1.HeatAPI) ([]corev1.Volume, []corev1.VolumeMount, error) { | |||
There was a problem hiding this comment.
Ok, I think this is working now. So, ideally, I would like these to be generic enough that we can use them for each deployment without reimplementing and duplicating the code.
Moving back to draft while I work on that.
Move mounts and volumes to dedicated function. This declutters the Deployment logic and makes each component easier to test. Particularly for Heat where we have some challenges with EnvTest and mocking the OpenStack API.