fix erroneous mismatched_geometry warning for preset-less tags
#10523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-yle
force-pushed
the
kh/10522-mismatched-geom
branch
from
5b85416
to
cd521a9
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10522
There is no preset for
disused:waterway=security_lock, so it matches the fallback presets (called "Line" and "Area"). But these two presets have different tags ({}vs{ area: 'yes' }) which caused the bug.This edge-case only occurs when the tag has a lifecycle prefix, because the preset for
waterway=*does not affect features with a lifecycle preset.