Add new field for SimulationControl: DoHVACSizingSimulationforSizingPeriods and MaximumNumberofHVACSizingSimulationPasses
#193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New fields at the bottom:
Tested the fields in the OSApp, checking the resulting OSM, and they work correctly. |
jmarrec
commented
Jul 21, 2020
Comment on lines
+66
to
+68
| * [#185](https://github.com/NREL/OpenStudioApplication/pull/185) - Support WaterCooled VRFs in OSApp | ||
|
|
||
| * [#193](https://github.com/NREL/OpenStudioApplication/pull/193) - Add new fields for SimulationControl: `DoHVACSizingSimulationforSizingPeriods` and `MaximumNumberofHVACSizingSimulationPasses` |
There was a problem hiding this comment.
Add a draft release note, and write the two new features in the works currently.
Comment on lines
+143
to
+144
| m_doHVACSizingSimulationforSizingPeriods(nullptr), | ||
| m_maximumNumberofHVACSizingSimulationPasses(nullptr), |
There was a problem hiding this comment.
Ctor initialize new fields in the right place to match hpp
There was a problem hiding this comment.
We should turn on static analysis to check this, http://cppcheck.sourceforge.net/
Comment on lines
+569
to
+577
| row = row + 2; | ||
| spacerItem = new QSpacerItem(1,SPACERITEM_HEIGHT,QSizePolicy::Fixed,QSizePolicy::Fixed); | ||
| gridLayout->addItem(spacerItem,row++,0); | ||
| col = 0; | ||
|
|
||
| addField(gridLayout,row,col,"Do HVAC Sizing Simulation for Sizing Periods",m_doHVACSizingSimulationforSizingPeriods); | ||
| col = col + 2; | ||
| addField(gridLayout,row,col,"Maximum Number of HVAC Sizing Simulation Passes",m_maximumNumberofHVACSizingSimulationPasses); | ||
|
|
There was a problem hiding this comment.
Add an switch and an integer edit for the two new fields
Comment on lines
+1389
to
+1404
| m_doHVACSizingSimulationforSizingPeriods->bind( | ||
| *m_simulationControl, | ||
| std::bind(&model::SimulationControl::doHVACSizingSimulationforSizingPeriods,m_simulationControl.get_ptr()), | ||
| boost::optional<BoolSetter>(std::bind(&model::SimulationControl::setDoHVACSizingSimulationforSizingPeriodsNoFail,m_simulationControl.get_ptr(),std::placeholders::_1)), | ||
| boost::optional<NoFailAction>(std::bind(&model::SimulationControl::resetDoHVACSizingSimulationforSizingPeriods,m_simulationControl.get_ptr())), | ||
| boost::optional<BasicQuery>(std::bind(&model::SimulationControl::isDoHVACSizingSimulationforSizingPeriodsDefaulted,m_simulationControl.get_ptr()))); | ||
|
|
||
| m_maximumNumberofHVACSizingSimulationPasses->bind( | ||
| *m_simulationControl, | ||
| IntGetter(std::bind(&model::SimulationControl::maximumNumberofHVACSizingSimulationPasses,m_simulationControl.get_ptr())), | ||
| boost::optional<IntSetter>(std::bind(&model::SimulationControl::setMaximumNumberofHVACSizingSimulationPasses,m_simulationControl.get_ptr(),std::placeholders::_1)), | ||
| boost::optional<NoFailAction>(std::bind(&model::SimulationControl::resetMaximumNumberofHVACSizingSimulationPasses,m_simulationControl.get_ptr())), | ||
| boost::none, | ||
| boost::none, | ||
| boost::optional<BasicQuery>(std::bind(&model::SimulationControl::isMaximumNumberofHVACSizingSimulationPassesDefaulted,m_simulationControl.get_ptr()))); | ||
|
|
There was a problem hiding this comment.
Bind the two new fields.
Comment on lines
+1981
to
+1982
| m_doHVACSizingSimulationforSizingPeriods->unbind(); | ||
| m_maximumNumberofHVACSizingSimulationPasses->unbind(); |
There was a problem hiding this comment.
Unbind them on detach
Comment on lines
+228
to
+229
| OSSwitch2 * m_doHVACSizingSimulationforSizingPeriods; | ||
| OSIntegerEdit2 * m_maximumNumberofHVACSizingSimulationPasses; |
There was a problem hiding this comment.
One switch for the YES/NO one, and one integer edit.
|
Want me to merge? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #192 - Add new field for SimulationControl:
DoHVACSizingSimulationforSizingPeriodsandMaximumNumberofHVACSizingSimulationPasses