Update to 3.1.0 SDK - punt on new shading controls UI #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macumber
commented
Sep 19, 2020
| // temporary workaround, see Shading Control Enhancements #239 | ||
| std::function<bool(model::SubSurface*, const model::ShadingControl&)> setter( | ||
| [](model::SubSurface* t_surface, const model::ShadingControl& t_arg) { | ||
| return const_cast<model::ShadingControl&>(t_arg).addSubSurface(*t_surface); |
There was a problem hiding this comment.
const_cast is ugly but ok for now
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel bad since you put a lot of effort into moving the shading controls UI @jmarrec
However, I feel that shading and daylighting controls in EnergyPlus are fundamentally broken. I think we should push to correct that implementation at the EnergyPlus and/or OpenStudio level before trying to make a new UI.
If we do make a new UI, I think that would be a larger new feature that would need support from the coalition or others. I created #239 and linked to a Google doc to play with ideas.
My suggestion is that we get our proposal on refactoring these controls ready, then bring to DOE/NREL and see if they can work with us on refactoring at the EnergyPlus and/or OpenStudio level