Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

OpenStudio Inspector does not support Imported Space Loads #8

Closed
eomere opened this issue Mar 4, 2020 · 2 comments · Fixed by #11
Closed

OpenStudio Inspector does not support Imported Space Loads #8

eomere opened this issue Mar 4, 2020 · 2 comments · Fixed by #11
Assignees
Labels
bug Something isn't working

Comments

@eomere
Copy link

eomere commented Mar 4, 2020

The OpenStudio Inspector does not support Space Loads. Hence, a User cannot access imported Space Loads (Extensions/OpenStudio/Import/Import Space Loads). The issue is present within both the Mac and Windows versions of the Plugin.

Will this feature be removed from menu options, or will the OpenStudio Inspector be updated to support Space Loads?

@jmarrec
Copy link
Contributor

jmarrec commented Mar 24, 2020

I thought originally you meant when importing from IDF, the loads (equipment, people, etc) isn't viewable (but it is in the OS Application), but I later realized you meant this:

image

So I thought this was a valid point: Constructions can be assigned to ConstructionSets and surfaces, Schedules can be set on the Default:ScheduleSet, but loads no.

After digging, this is actually just very badly named, and what it does is import Space Types from a custom OSM file.

https://github.com/NREL/openstudio-sketchup-plugin/blob/599c5fcad896bc1e8880c328930a16e57651016c/plugin/openstudio/lib/CommandManager.rb#L263-L284

This should just be renamed to convey the idea properly.

@eomere
Copy link
Author

eomere commented Mar 24, 2020

Good catch

macumber added a commit that referenced this issue Aug 14, 2020
Fix #8 - Rename "Import Space Loads" to "Import Space Types" as that's what it does
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
2 participants