This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds support for overriding target container name and Fargate platform version.
Notes
This PR aids in testing the changes in the following PRs:
Testing Instructions
Run
update
to ensure that the Django container image includes the changes onfeature/hmc/override-container-name
. Note that this includes the changes in Add support for supplying Fargate platform version azavea/django-ecsmanage#26 and Add support for overriding Django container name azavea/django-ecsmanage#27.Use
manage
to executeshowmigrations
in the staging ECS cluster; ensure that the platform version used by the task is 1.4.0$ ./scripts/manage ecsmanage showmigrations
manage
again to executeshowmigrations
; observe that the invocation fails due to there being no container in the task definition namedtest
Checklist
fixup!
commits have been squashed