Feat/mvds00/runtime version fixes #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvds00
force-pushed
the
feat/mvds00/runtime-version-fixes
branch
from
63517b5 to
542cc67
Compare
added 27 commits
February 27, 2025 12:30
…ore/after version change
…tions, explicitly use last block for extrinsics
…ctions, explicitly use last block for extrinsics
… of get_runtime()
…unction, improve 0x000... test
…function, improve 0x000... test
- add get_block_runtime_version_for() with large cache, to get runtime version required for block_hash - add small cache to get_parent_block_hash() and get_block_runtime_version() - rename get_block_runtime_version() to get_block_runtime_info()
- add get_block_runtime_version_for() with large cache, to get runtime version required for block_hash - add small cache to get_parent_block_hash() and get_block_runtime_version() - rename get_block_runtime_version() to get_block_runtime_info()
… inner function get_runtime(), add cache key runtime_version
added 23 commits
February 27, 2025 12:41
…me is not reloaded
…ion is already loaded
…sion is already loaded
…e it part of runtime object/cache
…ke it part of runtime object/cache
…on dependent properties from substrate to substrate.runtime
… version dependent properties from asyncsubstrate to asyncsubstrate.runtime
…type registry, as it depends on self.runtime
… type registry, as it depends on self.runtime
mvds00
force-pushed
the
feat/mvds00/runtime-version-fixes
branch
from
d033e4d to
04e7050
Compare
Merged
|
Moved to #65 to apply fixes. |
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft of reworked async_substrate_interface/sync_substrate.py
Reworked async_substrate.py along the same lines.
Please find a simple testcase in test_old_new.py (maybe change network to finney) which demonstrates that without the fix, switching between blocks pre- and post-dtao leads to errors.
In total, a lot has changed, but the changes are done step by step in a lot of small commits, such that the thought process can be followed. In case something breaks, this should also help to narrow down the breaking change.
Until
6d0c878c5fb63d6cd9dd6b3d214b6da9da7a71e8and6d0c878c5fb63d6cd9dd6b3d214b6da9da7a71e8^it is mostly refactoring, at which point the bug is pretty obvious, and fixed.The refactoring boils down to pushing all runtime_version related items to the runtime object, which is cached. The cache uses
runtime_versionas key (so notblock_hash), while additional caching is done at the point where the runtime_version is looked up for a block_hash/block_id.Further simplifications and cleanup are possible, but first let's see how this works out.