Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updates _load_registry_type_map #87

Merged
merged 3 commits into from
Mar 27, 2025
Merged

Conversation

ibraheem-opentensor
Copy link
Contributor

@ibraheem-opentensor ibraheem-opentensor commented Mar 27, 2025

Old

  • Single-pass approach: If a type depended on another type not yet processed, it was left unresolved.
  • Relied on order: Some types were skipped because they weren’t recognized in time.
  • Nested generics (like some Option) often stayed unresolved because of this.
  • Incomplete arrays/sequences: Definitions weren’t fully expanded.

New

  • Two-pass resolution: First map simple types; then iteratively resolve nested/complex ones.
  • Iterative handling: Re-check pending types until none remain, ensuring dependencies get picked up.
  • All generics resolved: Options and similar now properly map their inner types.

@github-actions github-actions bot added run-bittensor-cli-tests Runs BTCLI tests. run-bittensor-sdk-tests Runs Bittensor SDK tests. labels Mar 27, 2025
@ibraheem-opentensor ibraheem-opentensor requested a review from a team March 27, 2025 01:03
@ibraheem-opentensor ibraheem-opentensor self-assigned this Mar 27, 2025
@ibraheem-opentensor ibraheem-opentensor merged commit 510a6a1 into staging Mar 27, 2025
36 checks passed
This was referenced Mar 27, 2025
@thewhaleking thewhaleking deleted the update/load_registry branch March 27, 2025 13:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
run-bittensor-cli-tests Runs BTCLI tests. run-bittensor-sdk-tests Runs Bittensor SDK tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants