fix: concurrency crash on item attributes #3304
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the
Attributes
class by replacingstd::shared_ptr<std::string>
withstd::string
in thevalue
variant. The previous implementation introduced unnecessary heap allocations and potential crashes due to incorrect shared pointer management. The refactor ensures safer and more efficient handling of string attributes.Behaviour
Actual
If an attribute stored a
std::shared_ptr<std::string>
, there were cases where the reference was lost or improperly accessed, leading to crashes when trying to retrieve the string.Expected
Attributes now store
std::string
directly, preventing dangling pointers and reducing overhead related to shared pointer allocation and dereferencing.Type of change
How Has This Been Tested
Checklist