Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: aleta grav comportment #3398

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: aleta grav comportment #3398

wants to merge 2 commits into from

Conversation

dudantas
Copy link
Member

Description

This PR fixes multiple issues regarding house door list handling and door usage via the "aleta grav" spell. The changes ensure that:

  • The "House Door List" spell now works correctly when the player is both in front of and inside the door.
  • Both door lists are properly loaded from the database, and cached entries are cleared once applied.
  • The door usage check now validates that the player's current tile belongs to the same house as the door, preventing usage when the player is outside the house.

Behaviour

Actual

  • The "House Door List" spell did not work if the player was inside the door.
  • Only one of the door lists was loaded from the database, due to improper caching and iteration.
  • The system allowed door-based actions even when the player's tile was not within the associated house.

Expected

  • The "House Door List" spell functions correctly whether the player is in front of or inside the door.
  • Both door lists (e.g., guest list and door-specific list) are loaded properly and the cache is cleared after use.
  • Door usage is validated against the player's current position, ensuring that the action can only be performed when the player is inside the house.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

  • Tested with players casting "aleta grav" from both outside and inside a door.
  • Verified that both door lists are loaded from the database and the cache is properly cleared.
  • Confirmed that door actions are only permitted when the player is within the house.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant