-
Notifications
You must be signed in to change notification settings - Fork 299
build(sites): optimize build chunks num #2028
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
WalkthroughThe changes introduce a new dependency, Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Vite
participant delStatic
participant FileSystem
User->>Vite: Trigger build
Vite->>FileSystem: Build files
Vite->>delStatic: Execute cleanup
delStatic->>FileSystem: Remove *.spec.js and *.spec.ts files
FileSystem-->>delStatic: Confirm deletion
delStatic-->>Vite: Cleanup complete
Vite-->>User: Build finished
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
[e2e-test-warn] The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug". Please make sure you've read our contributing guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- examples/sites/package.json (1 hunks)
- examples/sites/vite.config.ts (3 hunks)
Files skipped from review due to trivial changes (1)
- examples/sites/package.json
Additional comments not posted (4)
examples/sites/vite.config.ts (4)
16-17
: LGTM!The new imports,
fast-glob
andfs-extra
, are relevant for thedelStatic
function introduced later in the file.
19-39
: LGTM!The
delStatic
function is a well-structured Vite plugin that enhances the build process by cleaning up unwanted test files. It follows the Vite plugin conventions and makes good use of thefast-glob
andfs-extra
libraries.
50-50
: LGTM!The changes to the
copyTarget
array refine the file copying behavior by limiting the scope to only the immediate files within the specified directories. This modification improves the precision of the file copying process.Also applies to: 54-54
103-103
: LGTM!Adding the
delStatic
function to the plugins array ensures that it is executed during the build process, effectively integrating the functionality of removing unwanted test files into the build pipeline.
* feat: gitHub-action remove runtime script * fix(anchor): 修复anchor点击后滚动响应滞后的问题,适配saas主题 (#1892) * feat: update package.json dependencies * fix(theme): Fixed the issue that multiple root files are generated when the theme is packaged. (#1893) * fix(theme): 删除无用的error-page文件导致打包多个root的问题 * fix(theme): 优化打包脚本 * fix: fix time-select build error * fix: split theme build error * fix(nav-menu): [nav-menu] error occurred when modifying route redirection (#1907) * fix(nav-menu): [nav-menu] error occurred when modifying route redirection * fix(nav-menu): [nav-menu] error occurred when modifying route redirection * fix(grid): [grid] fix panel flash in page (#1903) * fix(select): fix select for no-match-value 's bug (#1926) * docs(changelog): update 3.18.0 changelog (#1928) * fix(link): remove link's emits declare and add e2e test for click event (#1944) * fix(theme): fix theme dark style (#2019) * fix(theme): fix theme dark style * fix(theme): fix theme dark style * feat(docs): 文档增加切换主题提示 (#2024) * feat: update docs version * fix(tree): [tree] fix tree showLine props's bug , sometimes the line is too… (#2015) * fix(tree): fix tree showLine props's bug , sometimes the line is too long * fix(theme): update version * build(sites): optimize build chunks num (#2028) * feat: update vue-docs version * fix(docs): The theme switch prompt is placed in the lower right corner. (#2030) * fix(docs): 主题切换提示放到右下角 * fix(docs): 增加docs版本 * fix(modal): [modal] after the window size is changed, the window is displayed in the center (#2033) * fix(modal): [modal]dragging the modal box,will be displayed in the center * fix: modify review code * fix(modal): modify review code * fix: modify renderless of version * fix(grid): [grid] fix empty slot error when is-center-empty is set (#2051) * docs: fix demo anchor not correct (#2056) * feat: update docs version * Merge branch 'dev' of github.com:opentiny/tiny-vue into sync-3.18.0-to-dev --------- Co-authored-by: chenxi-20 <76168465+chenxi-20@users.noreply.github.com> Co-authored-by: wuyiping0628 <42107997+wuyiping0628@users.noreply.github.com> Co-authored-by: gimmyhehe <975402925@qq.com> Co-authored-by: 申君健 <40288193@qq.com> Co-authored-by: chenxi-20 <2465950588@qq.com> Co-authored-by: James <72028410+James-9696@users.noreply.github.com>
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Improvements