Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(tree-menu): [tree-menu] update dark theme #3157

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

wuyiping0628
Copy link
Collaborator

@wuyiping0628 wuyiping0628 commented Mar 19, 2025

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Style
    • Enhanced tree menu visuals with refined hover and selection color options to improve interactive feedback.
    • Introduced new color settings that clearly differentiate between when a node is hovered over versus selected.

@wuyiping0628 wuyiping0628 added the enhancement New feature or request (功能增强) label Mar 19, 2025
Copy link

coderabbitai bot commented Mar 19, 2025

Walkthrough

This update modifies the styling for the Tree Menu component. In the theme’s CSS files, new custom properties are introduced and applied to provide distinct color feedback for hovered and selected states of tree menu nodes. The changes involve updating both the node’s name hover color and the node’s body selected color, enhancing visual consistency in the tree menu.

Changes

Files Change Summary
packages/theme/src/tree-menu/index.less, packages/theme/src/tree-menu/vars.less Added new CSS custom properties and applied them to update the tree menu node colors. In index.less, the hover state of .tree-node-name now uses var(--tv-TreeMenu-node-name-hover-color) and the selected state of .tree-node-body uses var(--tv-TreeMenu-node-body-selected-color). In vars.less, new variables for these states are defined using existing color values.

Possibly related PRs

Suggested labels

bug

Suggested reviewers

  • zzcr

Poem

I'm a rabbit, hopping by,
Through lines of code that catch the eye.
Hover hues and selected shades align,
In tree menus that now brightly shine.
I nibble bugs and cheer the change,
Code so spry, beyond the range!
🥕💻 Hop on and enjoy the vibe!

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e38973c and e59771b.

📒 Files selected for processing (2)
  • packages/theme/src/tree-menu/index.less (2 hunks)
  • packages/theme/src/tree-menu/vars.less (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (3)
packages/theme/src/tree-menu/index.less (2)

216-219: Dark Theme Hover State Styling for Node Names
The new hover styling in the .tree-node-name selector now applies var(--tv-TreeMenu-node-name-hover-color), ensuring that hover interactions are clearly visible in dark mode. This change aligns well with the dark theme update objective.


254-258: Dark Theme Selected State Styling Update
The update in the .is-current block now uses var(--tv-TreeMenu-node-body-selected-color) for the .tree-node-body, which provides a clear visual cue for selected nodes in dark mode. This improves the consistency of the theme and meets the de#tent described in the PR.

packages/theme/src/tree-menu/vars.less (1)

80-83: Introduction of Dark Theme CSS Custom Properties
The new CSS variables --tv-TreeMenu-node-body-selected-color and --tv-TreeMenu-node-name-hover-color are correctly defined, pulling values from existing design tokens (var(--tv-color-border-active) and var(--tv-color-border-hover)). This approach is clean and ensures consistent theming across the tree menu component.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Walkthrough

This pull request updates the dark theme for the tree-menu component by adding new CSS variables for hover and selected text colors. These changes aim to enhance the visual appearance of the tree-menu in dark mode.

Changes

File Summary
packages/theme/src/tree-menu/index.less Added CSS rules for hover and selected text colors in the tree-menu component.
packages/theme/src/tree-menu/vars.less Introduced new CSS variables for hover and selected text colors.

@github-actions github-actions bot added bug Something isn't working and removed enhancement New feature or request (功能增强) labels Mar 19, 2025
@zzcr zzcr merged commit 34b7233 into opentiny:dev Mar 19, 2025
11 of 15 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants