Skip to content

feat(theme): [select] modify the scrollbar and popper to unify the style #3160

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

MomoPoppy
Copy link
Collaborator

@MomoPoppy MomoPoppy commented Mar 19, 2025

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Style
    • Updated the dark theme: The scrollbar track now displays a transparent background for a cleaner look.
    • Refined global scrollbar styling: Styles are now uniformly applied across viewports with improved selectors.
    • Enhanced popover appearance: Adjusted conditions ensure styling is applied only when visual cues are present.

Copy link

coderabbitai bot commented Mar 19, 2025

Walkthrough

This update modifies two LESS files related to theme styling. In dark-theme.less, the scrollbar track background color is changed from a black value to transparent. In reset.less, the scrollbar styles are adjusted to apply universally by removing a media query, selectors are reorganized (including scrollbar-corner handling), and popover selectors are updated to target only those with a child arrow. These changes impact only visual styling without affecting functionality.

Changes

File(s) Change Summary
packages/theme/src/base/dark-theme.less Updated CSS variable --tv-color-bg-scrollbar-track from var(--tv-base-color-common-13) (black) to transparent.
packages/theme/src/base/reset.less Removed media query for scrollbar styles, reorganized scrollbar selectors (added ::-webkit-scrollbar-corner, removed ::-webkit-scrollbar-track-piece), and updated popover selectors to include :has(.popper__arrow).

Possibly related PRs

Suggested labels

enhancement

Suggested reviewers

  • zzcr

Poem

I'm a little rabbit, hopping in the night,
Tweaking theme styles with all my might.
Scrollbars turn transparent in a moonlit dance,
Popovers and arrows join the prance.
Code and whiskers in a joyful spree—
A celebration of CSS, wild and free!

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0b5a346 and e6e736f.

📒 Files selected for processing (2)
  • packages/theme/src/base/dark-theme.less (1 hunks)
  • packages/theme/src/base/reset.less (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (3)
packages/theme/src/base/dark-theme.less (1)

516-516: Scrollbar Track Background Update

The scrollbar track background color is now defined as transparent rather than using the dark common color. This update is pivotal for achieving the unified style envisioned in the PR. Please ensure that this transparent setting integrates well with all themes and that it doesn’t adversely affect visibility on different backgrounds.

packages/theme/src/base/reset.less (2)

155-182: Enhanced Scrollbar Styling with CSS Variables

The scrollbar styling has been reorganized to leverage CSS custom properties for width, height, and background colors. In particular, the ::-webkit-scrollbar, ::-webkit-scrollbar-corner, and ::-webkit-scrollbar-track selectors consistently use var(--tv-color-bg-scrollbar-track), ensuring visual alignment with the dark theme changes. Please verify this implementation in target browsers (notably WebKit-based ones) to confirm consistent rendering.


205-207: Refined Popper Selector with :has Pseudo-class

The updated selectors now apply styles only when the popover element contains a child with the .popper__arrow class, thanks to the new use of :has(.popper__arrow). This is a clean approach to restrict the styles to arrow-containing popovers. However, ensure that the browsers targeted by your project fully support the :has pseudo-class. It may be beneficial to include a note in your documentation regarding any known compatibility issues.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the enhancement New feature or request (功能增强) label Mar 19, 2025
Copy link

Walkthrough

This pull request modifies the scrollbar and popper styles in the tiny-vue theme to unify their appearance. The changes involve setting the scrollbar track to be transparent and adjusting the popper styles to ensure consistent styling across components.

Changes

File Summary
packages/theme/src/base/dark-theme.less Changed scrollbar track color to transparent.
packages/theme/src/base/reset.less Unified scrollbar styles and adjusted popper styles for elements with arrows.

.tiny-popconfirm-popover,
.tiny-popper,
.tiny-tooltip__popper {
.tiny-popconfirm-popover:has(.popper__arrow),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of :has() pseudo-class is not supported in all browsers. Ensure compatibility with your target browsers or provide a fallback.

@zzcr zzcr merged commit 9d5e3d3 into opentiny:dev Mar 19, 2025
24 of 36 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request (功能增强)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants