fix(theme): [skeleton,collapse] update dark theme #3219
Conversation
WalkthroughThe changes update several styling rules. Two Vue component files now include a CSS property that sets the fill color of the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
examples/sites/demos/pc/app/collapse/title.vueOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. examples/sites/demos/pc/app/collapse/title-composition-api.vueOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (5)
🔇 Additional comments (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis PR updates the dark theme for the skeleton and collapse components in the Tiny Vue project. It includes changes to CSS variables and styles to enhance the visual appearance and consistency of these components in dark mode. Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/theme/src/skeleton-item/vars.less (1)
7-7: CSS Variable Update for Dark ThemeThe change updates the image icon color variable to use
var(--tv-color-icon-disabled, #c2c2c2), which aligns with the dark theme requirements. Please verify that this new color integrates seamlessly with the rest of the dark theme palette and maintains adequate contrast.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
examples/sites/demos/pc/app/collapse/title-composition-api.vue(1 hunks)examples/sites/demos/pc/app/collapse/title.vue(1 hunks)packages/theme/src/collapse-item/index.less(2 hunks)packages/theme/src/collapse-item/vars.less(1 hunks)packages/theme/src/skeleton-item/vars.less(1 hunks)
🔇 Additional comments (5)
examples/sites/demos/pc/app/collapse/title-composition-api.vue (1)
58-61: Consistent theme styling for iconAdding the fill property using the CSS variable
--tv-color-iconwith a fallback to #808080 ensures the icon's color is consistent with the theming system. This is a good improvement for dark theme support.examples/sites/demos/pc/app/collapse/title.vue (1)
66-69: Consistent theme styling for iconThe addition of the fill property using
--tv-color-iconwith a fallback matches the implementation in the composition API version, ensuring consistent styling across different Vue API styles. This change properly supports the dark theme requirements for the icon.packages/theme/src/collapse-item/vars.less (1)
16-18: Updated background color variable for dark theme compatibilityChanging the background color variable from
--tv-color-bg-gray-1, #fafafato--tv-color-bg-3, #ffffffis appropriate for better dark theme support. The--tv-color-bg-3variable likely has proper dark mode mappings in the theming system.packages/theme/src/collapse-item/index.less (2)
61-65: Enhanced hover interaction for title elementsAdding the underline text decoration on hover for the title__right element improves user feedback and accessibility by making interactive elements more obvious. This is a good enhancement for the collapse component UI.
105-107: Improved visual separation with content borderAdding a border-top to the content element creates better visual separation between the header and content areas. Using the same color variable as other borders (
--tv-CollapseItem-header-border-color) maintains consistency in the design.
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit