Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove unwanted dependencies in Raptor code #6163

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

t2gran
Copy link
Member

@t2gran t2gran commented Oct 15, 2024

Summary

A few small cleanup tasks to Raptor to prepare for making it a separate Maven module.

Issue

Part of: #6155

Unit tests

This only contains simple refactorings, no tests added or changed.

Documentation

No

Changelog

No

Bumping the serialization version id

Not needed

@t2gran t2gran added this to the 2.7 (next release) milestone Oct 15, 2024
@t2gran t2gran requested a review from a team as a code owner October 15, 2024 22:16
…pScheduleBoardSearch, and ValueObjectToStringBuilder.
@t2gran t2gran force-pushed the raptor_application_integration branch from 4aa5765 to 7b4be49 Compare October 16, 2024 11:05
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 57.89474% with 16 lines in your changes missing coverage. Please review.

Project coverage is 69.92%. Comparing base (f49ad47) to head (87cbb05).
Report is 107 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...opentripplanner/raptor/configure/RaptorConfig.java 60.00% 3 Missing and 1 partial ⚠️
.../config/routerconfig/RaptorEnvironmentFactory.java 42.85% 3 Missing and 1 partial ⚠️
...anner/raptor/service/RangeRaptorDynamicSearch.java 0.00% 3 Missing ⚠️
...nner/standalone/config/configure/ConfigModule.java 0.00% 3 Missing ⚠️
...pplanner/raptor/api/request/RaptorEnvironment.java 75.00% 1 Missing ⚠️
...er/raptor/service/ViaRangeRaptorDynamicSearch.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6163      +/-   ##
=============================================
+ Coverage      69.90%   69.92%   +0.01%     
- Complexity     17700    17729      +29     
=============================================
  Files           1996     1998       +2     
  Lines          75305    75406     +101     
  Branches        7705     7718      +13     
=============================================
+ Hits           52644    52727      +83     
- Misses         19990    20000      +10     
- Partials        2671     2679       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Henrik Abrahamsson <127481124+habrahamsson-skanetrafiken@users.noreply.github.com>
@t2gran t2gran merged commit 0ae34a8 into opentripplanner:dev-2.x Oct 21, 2024
5 checks passed
@t2gran t2gran deleted the raptor_application_integration branch October 21, 2024 14:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants