-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Interpret GTFS extended route types 801-899 also as trolleybus service #6170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If someone is using extended types between 800-899, this will change the output mode but I think they are quite rare. I would be ok with merging these changes.
application/src/test/java/org/opentripplanner/gtfs/mapping/TransitModeMapperTest.java
Outdated
Show resolved
Hide resolved
@flaktack does this affect your deployments? |
No, merging is fine with us. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6170 +/- ##
=============================================
+ Coverage 69.93% 69.96% +0.03%
- Complexity 17730 17749 +19
=============================================
Files 1996 1996
Lines 75402 75416 +14
Branches 7717 7717
=============================================
+ Hits 52731 52767 +36
+ Misses 19995 19979 -16
+ Partials 2676 2670 -6 ☔ View full report in Codecov by Sentry. |
Summary
Fix GTFS extended route types for trolleybus (8xx).
This replaces #6086 for trolleybuses only, and add tests for existing modes (except 200-299).
Issue
None yet
Unit tests
added for more existing modes
Documentation
None