Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Interpret GTFS extended route types 801-899 also as trolleybus service #6170

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

miklcct
Copy link
Contributor

@miklcct miklcct commented Oct 17, 2024

Summary

Fix GTFS extended route types for trolleybus (8xx).

This replaces #6086 for trolleybuses only, and add tests for existing modes (except 200-299).

Issue

None yet

Unit tests

added for more existing modes

Documentation

None

@miklcct miklcct requested a review from a team as a code owner October 17, 2024 11:05
Copy link
Member

@optionsome optionsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone is using extended types between 800-899, this will change the output mode but I think they are quite rare. I would be ok with merging these changes.

@optionsome
Copy link
Member

@flaktack does this affect your deployments?

@flaktack
Copy link
Contributor

No, merging is fine with us.

@t2gran t2gran added this to the 2.7 (next release) milestone Oct 22, 2024
@optionsome optionsome changed the title Fix trolleybus GTFS type Interpret GTFS extended route types 801-899 also as trolleybus service Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.96%. Comparing base (440498f) to head (191aec2).
Report is 81 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...pentripplanner/gtfs/mapping/TransitModeMapper.java 84.61% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6170      +/-   ##
=============================================
+ Coverage      69.93%   69.96%   +0.03%     
- Complexity     17730    17749      +19     
=============================================
  Files           1996     1996              
  Lines          75402    75416      +14     
  Branches        7717     7717              
=============================================
+ Hits           52731    52767      +36     
+ Misses         19995    19979      -16     
+ Partials        2676     2670       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@optionsome optionsome merged commit a1c8bd8 into opentripplanner:dev-2.x Oct 28, 2024
5 checks passed
t2gran pushed a commit that referenced this pull request Oct 28, 2024
@miklcct miklcct deleted the trolleybus_gtfs branch November 26, 2024 16:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants